From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439AbdIEHe1 (ORCPT ); Tue, 5 Sep 2017 03:34:27 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:52552 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbdIEHeW (ORCPT ); Tue, 5 Sep 2017 03:34:22 -0400 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Arnd Bergmann , Wayne Porter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rts5208: fix gcc-8 logic error warning Date: Tue, 5 Sep 2017 09:33:32 +0200 Message-Id: <20170905073415.183584-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:aQP6u7kEJaoeF802piipvSXOTro0xI0gG7UESQdaUofUKvji+FZ D6SogIqOaHnYYLaNd4PmCxmWqUJ3CVp/jSyABg2iEfmfSUjSSpC3MDbJA8hmaSrzOl2/+AH ULJlSyiED9GhokJ4PecR34g8g1gmCrysH/mJLPVr7k2JdsKJtgSI20wbl6+jq2d+EZsXDzb rjFcvKB9VfSw2OYp1ACNQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Xz134tHjeHQ=:OUC7JVrIz4nQxLVVJ1xJ3g faslTlQr86TV1yyvU+t2wAIP93pJ+Gc+kL5aqLF99ooFqDp3WbviDtfLxGBl9dSpn/T/E12GB PaPy5EvfgwjuiwJQwZE8bfwJvcyfds8T1j1DHcbl18ZHUpd4FWYWnSmdSOWetcXLr9yPF3rId RfySpanC3JQEd51lRnJ8GioXqc/ZHaPBI7DywtwkyUwOSlD0j2Z7F7Spa9S3k4jzYiogQNqvl qWiuf3whrCefQ3E+dIafiZXBPjU8QH4BKmkrn841uxmSErJlo7Wq3SAN72eD147X8e4zkBNot GIhnEPS09lBLGgvxDd3l0riJVdJAQ5Ir64uWT4BBzSp303HN8kI6wWC7pdOVuS6wxzL2LYM/R D4UyrJ0vsiq0XHqpwccj6GH6n9qqoBHK1EjZnmUe0ij/y5PqAwPIbZJyYZnIQ5DGGOpUPpQvA FlMhsaSMC3TOQmRoKjXKcS9P434jx5MuNlkLfSJFnZno7xS8GTwcip5SlOpiWaHadJuTYZcbh vuv891vsWXLeEr4vJ7/KojLcEytg9HWBabBPGQojX9gkhejxtuJWDEjP2Bt6jngsI7eQ4PWyJ 2e6Nw/TP6t6cM/zYhMcQcNrro7pqxjKxQsS3R8Or7m3at9ImyUfKzJj8GKxGppp2ZE6+XrSEr t2vysPyyjgvv60AoUiq7/nhmk6QKVz7oq/by0lBRnQPCfJgaOZop5A5NWcu0RdLfg0MPEnm+9 ILgf8wqXLmjN2bavP1rS61vttdjouGb1i3jFPg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As gcc-8 points out, the bit mask check makes no sense here: drivers/staging/rts5208/sd.c: In function 'ext_sd_send_cmd_get_rsp': drivers/staging/rts5208/sd.c:4130:25: error: bitwise comparison always evaluates to true [-Werror=tautological-compare] However, the code is even more bogus, as we have already checked for the SD_RSP_TYPE_R0 case earlier in the function and returned success. As seen in the mmc/sd driver core, SD_RSP_TYPE_R0 means "no response" anyway, so checking for a particular response would not help either. This just removes the nonsensical code to get rid of the warning. Signed-off-by: Arnd Bergmann --- drivers/staging/rts5208/sd.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c index 4033a2cf7ac9..d548bc695f9e 100644 --- a/drivers/staging/rts5208/sd.c +++ b/drivers/staging/rts5208/sd.c @@ -4125,12 +4125,6 @@ int ext_sd_send_cmd_get_rsp(struct rtsx_chip *chip, u8 cmd_idx, u32 arg, rtsx_trace(chip); return STATUS_FAIL; } - - } else if (rsp_type == SD_RSP_TYPE_R0) { - if ((ptr[3] & 0x1E) != 0x03) { - rtsx_trace(chip); - return STATUS_FAIL; - } } } } -- 2.9.0