From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751727AbdIEIKy (ORCPT ); Tue, 5 Sep 2017 04:10:54 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:61614 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751630AbdIEIKq (ORCPT ); Tue, 5 Sep 2017 04:10:46 -0400 From: Arnd Bergmann To: Christoph Hellwig , Marek Szyprowski , Greg Kroah-Hartman Cc: Arnd Bergmann , Robin Murphy , Vladimir Murzin , Mark Craske , "George G. Davis" , Bastian Hecht , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH] dma-coherent: fix dma_declare_coherent_memory() logic error Date: Tue, 5 Sep 2017 10:10:09 +0200 Message-Id: <20170905081026.1198405-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Gv6WhhwVw8nRe6kJFiEQv+KnlGmx52VA4nRcmLgPAiTAN4EeV9B bESjUF6tbhLIrAj8M5zs0QGOBO/H24toPpJgwVO9YMhhLE7sRVI/mTX3N/r/ttkn95+7soB ZuzBOumpld53CX29ouWp3M0B/jQpgw96/hsanZ/TxUS4p/nceBB4iTZ6eqnXwfOYQaQ+Nxm X7HAofCxxMEW++kT+JaTw== X-UI-Out-Filterresults: notjunk:1;V01:K0:n2fV/L8xxzE=:9mmz7varWaHqZ4qeQ5mCHz nW24ZIJqgaQAQcD2WwjdDLezwvI8x9Lc8Viv8LEWFHktOFXarvNhJh+66HKOBwJ9W+lKZD9VR wmXYX7F7PXkgdkKSvDBY8n9e19cMU4u4SrSEpNo2S34rd/rmzKCfwWCCiP/u2n2RiIR0xtxaL W6qwEWz9prlOyY6VbBXCzAFwbPVzNSm1XXGBdWqGG89/iMbUClDhBrTFctn00hYjyNk/s1oKh qX+0DqIt8PSUCgiCsXb87bY36RnVT2F+KE8tkLZyEONsSd8PEqlB6pGr+g3P6jYRXtyH/Wd44 1dNlLlNOcDFsNeDT0rZ6y+Y760J9S4V1siXcZZYhb4luA7LCsn9kwEuD/O1en7CLa0+4nUF0l y6ugEklkQ+zMhAdQp1gkxQ0aB5uUwtB1XLRbPjy4U51hQulJFgI4zVAm3os84SYz3ijUd53+z nv3Xn+r8bZ7E/3qdoax7IhBnVuVe45Sb47uaM9RqRdTrJO4hsBUdGlkCnIjsEdq6vvIhoEZMq Z0EOtnf4j+Fe6xtQzATO9zQfdzyrpDnXocUCcglOSR5HwbLvRcdbOMm5LcSeVPNhDQEIFtHav xSjvQPIOoTdo6pPSRQKtBqzElLHpGGSKKWZnHMeji+fX7sIIPGnlbeTssMpA+xHg2FqPNENQX fByuuQ+Nyr8FntpoU465cbfNZPciPIMHUucZOrWsmuelpWzXAkkkLiyPal418jQYhrHu3IVpX MHOCl8HtRCAdOC8IqjjkIKZh+wqtS4w+KgwHhA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A recent change interprets the return code of dma_init_coherent_memory as an error value, but it is instead a boolean, where 'true' indicates success. This leads causes the caller to always do the wrong thing, and also triggers a compile-time warning about it: drivers/base/dma-coherent.c: In function 'dma_declare_coherent_memory': drivers/base/dma-coherent.c:99:15: error: 'mem' may be used uninitialized in this function [-Werror=maybe-uninitialized] I ended up changing the code a little more, to give use the usual error handling, as this seemed the best way to fix up the warning and make the code look reasonable at the same time. Fixes: 2436bdcda53f ("dma-coherent: remove the DMA_MEMORY_MAP and DMA_MEMORY_IO flags") Signed-off-by: Arnd Bergmann --- drivers/base/dma-coherent.c | 38 +++++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/base/dma-coherent.c b/drivers/base/dma-coherent.c index f82a504583d4..a39b2166b145 100644 --- a/drivers/base/dma-coherent.c +++ b/drivers/base/dma-coherent.c @@ -37,7 +37,7 @@ static inline dma_addr_t dma_get_device_base(struct device *dev, return mem->device_base; } -static bool dma_init_coherent_memory( +static int dma_init_coherent_memory( phys_addr_t phys_addr, dma_addr_t device_addr, size_t size, int flags, struct dma_coherent_mem **mem) { @@ -45,20 +45,28 @@ static bool dma_init_coherent_memory( void __iomem *mem_base = NULL; int pages = size >> PAGE_SHIFT; int bitmap_size = BITS_TO_LONGS(pages) * sizeof(long); + int ret; - if (!size) + if (!size) { + ret = -EINVAL; goto out; + } mem_base = memremap(phys_addr, size, MEMREMAP_WC); - if (!mem_base) + if (!mem_base) { + ret = -EINVAL; goto out; - + } dma_mem = kzalloc(sizeof(struct dma_coherent_mem), GFP_KERNEL); - if (!dma_mem) + if (!dma_mem) { + ret = -ENOMEM; goto out; + } dma_mem->bitmap = kzalloc(bitmap_size, GFP_KERNEL); - if (!dma_mem->bitmap) + if (!dma_mem->bitmap) { + ret = -ENOMEM; goto out; + } dma_mem->virt_base = mem_base; dma_mem->device_base = device_addr; @@ -68,13 +76,13 @@ static bool dma_init_coherent_memory( spin_lock_init(&dma_mem->spinlock); *mem = dma_mem; - return true; + return 0; out: kfree(dma_mem); if (mem_base) memunmap(mem_base); - return false; + return ret; } static void dma_release_coherent_memory(struct dma_coherent_mem *mem) @@ -338,14 +346,18 @@ static struct reserved_mem *dma_reserved_default_memory __initdata; static int rmem_dma_device_init(struct reserved_mem *rmem, struct device *dev) { struct dma_coherent_mem *mem = rmem->priv; + int ret; + + if (!mem) + return -ENODEV; - if (!mem && - !dma_init_coherent_memory(rmem->base, rmem->base, rmem->size, - DMA_MEMORY_EXCLUSIVE, - &mem)) { + ret = dma_init_coherent_memory(rmem->base, rmem->base, rmem->size, + DMA_MEMORY_EXCLUSIVE, &mem); + + if (ret) { pr_err("Reserved memory: failed to init DMA memory pool at %pa, size %ld MiB\n", &rmem->base, (unsigned long)rmem->size / SZ_1M); - return -ENODEV; + return ret; } mem->use_dev_dma_pfn_offset = true; rmem->priv = mem; -- 2.9.0