From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751629AbdIEIQW (ORCPT ); Tue, 5 Sep 2017 04:16:22 -0400 Received: from merlin.infradead.org ([205.233.59.134]:49870 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbdIEIQS (ORCPT ); Tue, 5 Sep 2017 04:16:18 -0400 Date: Tue, 5 Sep 2017 10:16:03 +0200 From: Peter Zijlstra To: =?utf-8?B?77+92rrvv73Dti/vv73vv73vv73Tv++/ve+/ve+/ve+/ve+/vS9TVyBQbGF0?= =?utf-8?B?Zm9ybSjvv73vv70pQU9U77+977+9KGJ5dW5nY2h1bC5wYXJrQGxnZS5jb20p?= Cc: "tj@kernel.org" , "johannes.berg@intel.com" , "mingo@kernel.org" , "tglx@linutronix.de" , "oleg@redhat.com" , "david@fromorbit.com" , "linux-kernel@vger.kernel.org" , "kernel-team@lge.com" Subject: Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush Message-ID: <20170905081603.nfo5lg3cb6klrfw7@hirez.programming.kicks-ass.net> References: <1504578554-4137-1-git-send-email-byungchul.park@lge.com> <1504578554-4137-4-git-send-email-byungchul.park@lge.com> <20170905072551.fvtxrhuo662jiwif@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 05, 2017 at 04:36:18PM +0900, �ں�ö/���ӿ�����/SW Platform(��)AOT��(byungchul.park@lge.com) wrote: > > -----Original Message----- > > From: Peter Zijlstra [mailto:peterz@infradead.org] > > Sent: Tuesday, September 05, 2017 4:26 PM > > To: Byungchul Park > > Cc: tj@kernel.org; johannes.berg@intel.com; mingo@kernel.org; > > tglx@linutronix.de; oleg@redhat.com; david@fromorbit.com; linux- > > kernel@vger.kernel.org; kernel-team@lge.com > > Subject: Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt > > workqueue flush > > > > On Tue, Sep 05, 2017 at 11:29:14AM +0900, Byungchul Park wrote: > > > > > Also, lock_map_acquire() in process_one_work() is too strong for that > > > purpose. lock_map_acquire_might() is enough. Replaced it. > > > > NAK!! traditional annotations are superior to cross-release. They are not > > timing dependent. > > You seem to mis-understand this. This also make them timing independent. > I also agree that we need timing independent report in workqueue code. > That's actually why I propose this patch. Then clearly it needs comments and changelog to explain how it does things.