From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbdIEIcK (ORCPT ); Tue, 5 Sep 2017 04:32:10 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:54147 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbdIEIcH (ORCPT ); Tue, 5 Sep 2017 04:32:07 -0400 From: Arnd Bergmann To: arm@kernel.org, "David S. Miller" Cc: Dave Jiang , netdev@vger.kernel.org, Arnd Bergmann , "Karicheri, Muralidharan" , linux-kernel@vger.kernel.org Subject: [PATCH] soc: ti/knav_dma: include dmaengine header Date: Tue, 5 Sep 2017 10:31:35 +0200 Message-Id: <20170905083146.1289546-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:o0v+92kIxBQ/8VQPgoMYxg2whroulUGcyNMT/WSyMxcdD5jwgpH T1mjXKEWj/LmeuDu0Hyv90Vgz8Ev59j7Usp/7nCRplq+HlL2lIGD07k0PBTCkMWKUyY7+k9 aJ/iX4RAFyykIth9bbXgz5BNJfRsSqHDTjd6ZD+5UYBiYH9JmdBk6cZDVf9HvoH4Icygwxm 9OOZLHtrjDIEvGo8E/4RA== X-UI-Out-Filterresults: notjunk:1;V01:K0:I3RwZ0Fw1A0=:/NpW+yVftUs9ga2MXPb6lh JZ88uQovAkG0ZXmVY9N9XHBUGYHVYfxAZzXaWh06ojw7/p4wXdbyF32DzrWSqvABKbym2siBL 16JORiERMsJdPAQwVdmijGllkIeBuN6n/LN7q15ULF3NAVGpjro6BccYBGQyg5ra+5Cv2Aa9D OO8OzcPu2XTiPva2yUEPb2llXe18iu2yN/omqA6p28XjRpezweY/WWGJd0zuAY9JcA6D/JOcr yhPgWbfc53diYyBTXXtlnsXOBBFcPI5IfvjfahgjGblISj0+vAqdQNomZvQMxHa3i3uzh7gNO Mnm2pF5PufWckNwKs4pWN23I4JJgFiNXOCdJOWBbVmpNJdwLS9N89IGHpvQbCi3+FE2oksj8m MGQjr8AM4AgZagpvdCCHSbXp4PD0w7CvbBS+cltexWln5tjVcps8dkphCP/cN2hpGBfApP450 e3cTl2w//zrHE7LZVJWzVoX7kz3t8pyT5no/UXP7FC/4zinUh9iJ5EvR0NalKSe/VDJN/UaIk w/JHvE3wDvp7JALqRIosVKeqQ+VQGLyG5TBkRdSKhroDmMgBMijyGVV202dJoFXkhKaOgl1gP ugVypD7hx4UuL9XaWjuVWYPdo1hVs4HfG5i7SAfR737tJavLdBHlDrW5r0OqPY+UZNcG2ciMT pqWFLbH0kWMLfy+yh35a+4t9NynByPbo3AFq8Hb+fbIAGFQQ9f+mpXlV18ZuCKCUJmCaebZ+R vaR3J60hgxPiieKf3lozfEJAASS4G8HOxsNAKA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A header file cleanup apparently caused a build regression with one driver using the knav infrastructure: In file included from drivers/net/ethernet/ti/netcp_core.c:30:0: include/linux/soc/ti/knav_dma.h:129:30: error: field 'direction' has incomplete type enum dma_transfer_direction direction; ^~~~~~~~~ drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_txpipe_open': drivers/net/ethernet/ti/netcp_core.c:1349:21: error: 'DMA_MEM_TO_DEV' undeclared (first use in this function); did you mean 'DMA_MEMORY_MAP'? config.direction = DMA_MEM_TO_DEV; ^~~~~~~~~~~~~~ DMA_MEMORY_MAP drivers/net/ethernet/ti/netcp_core.c:1349:21: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_setup_navigator_resources': drivers/net/ethernet/ti/netcp_core.c:1659:22: error: 'DMA_DEV_TO_MEM' undeclared (first use in this function); did you mean 'DMA_DESC_HOST'? config.direction = DMA_DEV_TO_MEM; As the header is no longer included implicitly through netdevice.h, we should include it in the header that references the enum. Fixes: 0dd5759dbb1c ("net: remove dmaengine.h inclusion from netdevice.h") Signed-off-by: Arnd Bergmann --- If the cleanup patch hasn't been submitted for mainline yet, please add this fixup to the net-next tree, otherwise I'll merge it through arm-soc. --- include/linux/soc/ti/knav_dma.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/soc/ti/knav_dma.h b/include/linux/soc/ti/knav_dma.h index 2b7882666ef6..66693bc4c6ad 100644 --- a/include/linux/soc/ti/knav_dma.h +++ b/include/linux/soc/ti/knav_dma.h @@ -17,6 +17,8 @@ #ifndef __SOC_TI_KEYSTONE_NAVIGATOR_DMA_H__ #define __SOC_TI_KEYSTONE_NAVIGATOR_DMA_H__ +#include + /* * PKTDMA descriptor manipulation macros for host packet descriptor */ -- 2.9.0