From: Dave Jones <davej@codemonkey.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: x86/kconfig: Consolidate unwinders into multiple choice selection
Date: Tue, 5 Sep 2017 13:09:53 -0400 [thread overview]
Message-ID: <20170905170953.gqqrnmeahoojrdwz@codemonkey.org.uk> (raw)
On Mon, Sep 04, 2017 at 08:05:13PM +0000, Linux Kernel wrote:
> Web: https://git.kernel.org/torvalds/c/81d387190039c14edac8de2b3ec789beb899afd9
> Commit: 81d387190039c14edac8de2b3ec789beb899afd9
> Parent: a34a766ff96d9e88572e35a45066279e40a85d84
> Refname: refs/heads/master
> Author: Josh Poimboeuf <jpoimboe@redhat.com>
> AuthorDate: Tue Jul 25 08:54:24 2017 -0500
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Wed Jul 26 14:05:36 2017 +0200
>
> x86/kconfig: Consolidate unwinders into multiple choice selection
>
> There are three mutually exclusive unwinders. Make that more obvious by
> combining them into a multiple-choice selection:
>
> CONFIG_FRAME_POINTER_UNWINDER
> CONFIG_ORC_UNWINDER
> CONFIG_GUESS_UNWINDER (if CONFIG_EXPERT=y)
The help texts for the various unwinders are now attached to the wrong
kconfig item.
> +choice
> + prompt "Choose kernel unwinder"
> + default FRAME_POINTER_UNWINDER
> + ---help---
> + This determines which method will be used for unwinding kernel stack
> + traces for panics, oopses, bugs, warnings, perf, /proc/<pid>/stack,
> + livepatch, lockdep, and more.
This is what gets displayed, but tells me nothing about what the
benefits/downsides are of each (or even what they are; I had to read the
Kconfig file to figure out what 'GUESS' meant)
an oldconfig run ..
Choose kernel unwinder
> 1. Frame pointer unwinder (FRAME_POINTER_UNWINDER) (NEW)
2. ORC unwinder (ORC_UNWINDER) (NEW)
3. Guess unwinder (GUESS_UNWINDER) (NEW)
choice[1-3?]: ?
This determines which method will be used for unwinding kernel stack
traces for panics, oopses, bugs, warnings, perf, /proc/<pid>/stack,
livepatch, lockdep, and more.
Prompt: Choose kernel unwinder
Location:
-> Kernel hacking
Defined at arch/x86/Kconfig.debug:359
Selected by: m
Choose kernel unwinder
> 1. Frame pointer unwinder (FRAME_POINTER_UNWINDER) (NEW)
2. ORC unwinder (ORC_UNWINDER) (NEW)
3. Guess unwinder (GUESS_UNWINDER) (NEW)
choice[1-3?]:
Dave
next reply other threads:[~2017-09-05 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 17:09 Dave Jones [this message]
2017-09-06 21:49 ` Josh Poimboeuf
2017-09-06 22:10 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905170953.gqqrnmeahoojrdwz@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome