mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: mingo@redhat.com, peterz@infradead.org, pbonzini@redhat.com
Cc: npiggin@gmail.com, paulmck@linux.vnet.ibm.com, dave@stgolabs.net,
	linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: [PATCH 2/6] kvm,async_pf: Use swq_has_sleepers()
Date: Tue,  5 Sep 2017 12:00:18 -0700	[thread overview]
Message-ID: <20170905190022.1474-3-dave@stgolabs.net> (raw)
In-Reply-To: <20170905190022.1474-1-dave@stgolabs.net>

... as we've got the new helper now. This caller already
does the right thing, hence no changes in semantics.

Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
 virt/kvm/async_pf.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c
index bb298a200cd3..57bcb27dcf30 100644
--- a/virt/kvm/async_pf.c
+++ b/virt/kvm/async_pf.c
@@ -106,11 +106,7 @@ static void async_pf_execute(struct work_struct *work)
 
 	trace_kvm_async_pf_completed(addr, gva);
 
-	/*
-	 * This memory barrier pairs with prepare_to_wait's set_current_state()
-	 */
-	smp_mb();
-	if (swait_active(&vcpu->wq))
+	if (swq_has_sleeper(&vcpu->wq))
 		swake_up(&vcpu->wq);
 
 	mmput(mm);
-- 
2.12.0

  parent reply	other threads:[~2017-09-05 19:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 19:00 [PATCH 0/6] swait: Introduce and use swq_has_sleepers Davidlohr Bueso
2017-09-05 19:00 ` [PATCH 1/6] sched/wait: Add swq_has_sleepers() Davidlohr Bueso
2017-10-11  8:27   ` Peter Zijlstra
2017-10-11 11:21     ` Paolo Bonzini
2017-10-11 11:29       ` Peter Zijlstra
2017-09-05 19:00 ` Davidlohr Bueso [this message]
2017-09-05 19:00 ` [PATCH 3/6] kvm,lapic: Justify use of swait_activate() Davidlohr Bueso
2017-09-05 19:00 ` [PATCH 4/6] x86,kvm: Fix apf_task_wake_one() serialization Davidlohr Bueso
2017-09-10  9:20   ` Paolo Bonzini
2017-09-10  9:24     ` Paolo Bonzini
2017-10-12  8:23       ` Peter Zijlstra
2017-09-05 19:00 ` [PATCH 5/6] kvm: Serialize wq active checks in kvm_vcpu_wake_up() Davidlohr Bueso
2017-09-05 19:00 ` [PATCH 6/6] kvm,powerpc: Serialize wq active checks in ops->vcpu_kick Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905190022.1474-3-dave@stgolabs.net \
    --to=dave@stgolabs.net \
    --cc=dbueso@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®