From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754223AbdIFBEj (ORCPT ); Tue, 5 Sep 2017 21:04:39 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:64992 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753657AbdIFBEU (ORCPT ); Tue, 5 Sep 2017 21:04:20 -0400 X-AuditID: b6c32a46-f790d6d000003bf5-34-59af49916a83 From: Jaechul Lee To: Krzysztof Kozlowski , Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, galaxyra@gmail.com, Jaechul Lee , Chanwoo Choi Subject: [PATCH v2 3/3] ASoC: samsung: Fix invalid argument when devm_gpiod_get is called Date: Wed, 06 Sep 2017 10:04:15 +0900 Message-id: <20170906010415.26952-4-jcsing.lee@samsung.com> X-Mailer: git-send-email 2.14.1 In-reply-to: <20170906010415.26952-1-jcsing.lee@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAz1Sa0hTYRj2O2c7O1qnTtP0U6GNA/1IcLnj1M/cKruxyECIKItYBz2o5S6c s9kFChWyubz+MIZUWJnWIF1DwtQWbXSz0FaahS0MukBpRWoWFLW52b/nfb/ned73+XhJXP5G mkKWm6y8YOIqGCJOctO/BqW3bO8pygi8RGg04MNQ69t3BBqf/ShFD6614Wj6zhkcjYy4ZejH qB1Dz/vPEcg54sVQXX+TFPmnTktR4Ooshtzz18FGSu+eqSH0t9qCMr3HVUfovdOdhL6x1wX0 Pb1jEv2MZ1WhbB+vLeO5El5Q8qZic0m5qVTH7Nhl2GzIys5Qp6tzUQ6jNHFGXsdsKShM31Ze EVqXUVZyFbZQq5ATRWbteq1gtll5ZZlZtOqY/Wo1q1Jn5KhYllVpMg+sY7NClIN8WYvfQVh+ xx698DNIVIFbpAOQJKQ18I5H5gCxIZgIn77pIRwgjpTTfQA+Hn4MIsU8gDVzXtmi4Jd7a6Tv BvDUj2/Ef9KXjsYFK4JOg00d9QsPCXQnBgf7I1Y43QVg4HM7HmbF0/vhxe8TkjCW0Kuhv/bG gpqi86BzcFoSWUoBhycn8PDoWFoLJ0eSwz6QfkhA54tnUc4WeKHubhTHw08PeqOBUuEH1w0Q EZwG0PdqLlrYAfSOthMRViYcclRjYYzTy6Dd/ycalIL2WnmEood250DUNB8Gvn7HIpmbAJxr fEk0g9R2EOMCibxFNJbyImthVSJnFG2mUlWx2egBC7eVtq0PdAwX+ABNAmYp1ezpLpJLuUrx mNEHIIkzCdTr/J4iOVXCHTvOC2aDYKvgRR/ICn1OC56ystgculST1aDW5GZosrPZnGwUuo0k 6uTNF3vldCln5Q/zvIUXFnUYGZtSBZYrdi9R6qq7h2qrhw4Fx9ZPmVrpDeVxrXu6nuhm98qo xr8C69x3r2O1xTh5eX5nkkLRkHt2oHrFPUbbvCbh/KqhFHXepksTbl0y3TD1qL4u5sj4RadX itXkaegZo3n89vAJTVB4a+jTNty/oui2/aZcCamypMzB93kDyXFCkJGIZZw6DRdE7h/eHpik cQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrELMWRmVeSWpSXmKPExsVy+t9jQd2JnusjDfZeV7W4cvEQk8XUh0/Y LK5/ec5qcXzlLGaLt/u7mS3On9/AbvHtSgeTxeVdc9gsZpzfx2TRuauf1eLwm3ZWi4srvjBZ bPi+ltGB12PD5yY2j52z7rJ7bFrVyeax7+0yNo++LasYPdZvucri8XmTXAB7FJdNSmpOZllq kb5dAlfGxMNdbAV/OCvm/bjL1sC4k6OLkYNDQsBE4ucG1y5GTg4hgXWMEv+213UxcgHZ3xkl Pp1uZwFJsAloSfQv6WEDsUUEljFJfP+YA1LELLCcUeLRkYWsIAlhgWiJ+X9PgDWwCKhKHG7b yA5i8wpYS8zY8xYsLiEgL3HuwW1mkMWcAjYSD85LQiy2lnjx7DL7BEaeBYwMqxglUwuKc9Nz i40KjPJSy/WKE3OLS/PS9ZLzczcxAkNy22Gt/h2Mj5fEH2IU4GBU4uGdsGldpBBrYllxZe4h RgkOZiUR3juO6yOFeFMSK6tSi/Lji0pzUosPMUpzsCiJ82b2zYgUEkhPLEnNTk0tSC2CyTJx cEo1MO6v/2mebzHxt6CYOH+A/w5XNxOriR5JXws8N831sN98809UyJr583XPxyxrNX/qLy1m x+xXezbt6I0dcfEVP+YU67EqSv9Pn37q2J6ZFrOTrswxYa53OnHgRsyT3JTz+bK6yxufCz2L N0tuKT+xMMrcQO32tqBZIizhl2c63G5smWb/cJ7NNCWW4oxEQy3mouJEAHAuoztFAgAA X-CMS-MailID: 20170906010417epcas2p1fa15cc68a8fb034f087b8103f6767f29 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?7J207J6s7LKgG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SmFlQ2h1bCBMZWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170906010417epcas2p1fa15cc68a8fb034f087b8103f6767f29 X-RootMTR: 20170906010417epcas2p1fa15cc68a8fb034f087b8103f6767f29 References: <20170906010415.26952-1-jcsing.lee@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_gpiod_get is called with GPIOF_OUT_INIT_LOW but the function doesn't allow the parameters. Unluckily, GPIOF_OUT_INIT_LOW is same value as GPIOD_ASIS and gpio direction isn't set properly. Muted stream comes up when I try recording some sounds on TM2. mic-bias gpiod state can't be changed because the gpiod is created with the invalid parameter. The gpio should be set GPIOD_OUT_HIGH. Fixes: 1bfbc260a5b4 ("ASoC: samsung: Add machine driver for Exynos5433 based TM2 board") Signed-off-by: Jaechul Lee --- sound/soc/samsung/tm2_wm5110.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c index 710e2151141f..a55d18703fe7 100644 --- a/sound/soc/samsung/tm2_wm5110.c +++ b/sound/soc/samsung/tm2_wm5110.c @@ -439,8 +439,7 @@ static int tm2_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, priv); card->dev = dev; - priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias", - GPIOF_OUT_INIT_LOW); + priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias", GPIOD_OUT_HIGH); if (IS_ERR(priv->gpio_mic_bias)) { dev_err(dev, "Failed to get mic bias gpio\n"); return PTR_ERR(priv->gpio_mic_bias); -- 2.14.1