From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932613AbdIFOlC (ORCPT <rfc822;w@1wt.eu>);
        Wed, 6 Sep 2017 10:41:02 -0400
Received: from mail-qk0-f195.google.com ([209.85.220.195]:32949 "EHLO
        mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932260AbdIFOk5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Sep 2017 10:40:57 -0400
X-Google-Smtp-Source: ADKCNb4TOAcVAV3TKpT0cjdW3tl8BaU4WjQSZQw7J4rdsqyEYlSIqhiSGqldBUF4c+4dxUh8cgV6yw==
Date: Wed, 6 Sep 2017 07:40:54 -0700
From: Tejun Heo <tj@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: zpodd: make arrays cdb static, reduces object
 code size
Message-ID: <20170906144054.GM1774378@devbig577.frc2.facebook.com>
References: <20170906085629.23938-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170906085629.23938-1-colin.king@canonical.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 06, 2017 at 09:56:29AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate the arrays cdb on the stack, instead make them static.
> Makes the object code smaller by 230 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    3797	    240	      0	   4037	    fc5	drivers/ata/libata-zpodd.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    3407	    400	      0	   3807	    edf	drivers/ata/libata-zpodd.o
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to libata/for-4.14.

Thanks.

-- 
tejun