From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754925AbdIFWq0 (ORCPT ); Wed, 6 Sep 2017 18:46:26 -0400 Received: from mga05.intel.com ([192.55.52.43]:39086 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753053AbdIFWqZ (ORCPT ); Wed, 6 Sep 2017 18:46:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,355,1500966000"; d="scan'208";a="132548035" From: Miguel Bernal Marin To: Josh Poimboeuf , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" Cc: linux-kernel@vger.kernel.org, x86@kernel.org Subject: [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm Date: Wed, 6 Sep 2017 17:44:58 -0500 Message-Id: <20170906224501.11816-1-miguel.bernal.marin@linux.intel.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170906052613.30058-1-miguel.bernal.marin@linux.intel.com> References: <20170906052613.30058-1-miguel.bernal.marin@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some warning were showed by objtool using gcc 7.2.0 kernel/locking/rwsem.o: warning: objtool: up_read()+0x11: call without frame pointer save/setup kernel/locking/rwsem.o: warning: objtool: up_write()+0x17: call without frame pointer save/setup kernel/locking/rwsem.o: warning: objtool: downgrade_write()+0x22: call without frame pointer save/setup which means gcc placed an inline asm function and its call instruction before the frame pointer setup. This series forces a stack frame to be created before the call instruction by listing the stack pointer as an output operand in the inline asm statement. Changes in v2: - Update first parameter from _ASM_ADD to '%3' at __downgrade_write() Miguel Bernal Marin (3): locking/rwsem/x86: Add stack frame dependency for __up_read() locking/rwsem/x86: Add stack frame dependency for __up_write() locking/rwsem/x86: Add stack frame dependency for __downgrade_write() arch/x86/include/asm/rwsem.h | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) -- 2.14.1