From: David Miller <davem@davemloft.net>
To: Haakon.Bugge@oracle.com
Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
linux-kernel@vger.kernel.org, knut.omang@oracle.com
Subject: Re: [PATCH net v2] rds: Fix incorrect statistics counting
Date: Thu, 07 Sep 2017 20:07:33 -0700 (PDT) [thread overview]
Message-ID: <20170907.200733.1562967291105061977.davem@davemloft.net> (raw)
In-Reply-To: <20170906163551.20387-1-Haakon.Bugge@oracle.com>
From: Håkon Bugge <Haakon.Bugge@oracle.com>
Date: Wed, 6 Sep 2017 18:35:51 +0200
> In rds_send_xmit() there is logic to batch the sends. However, if
> another thread has acquired the lock and has incremented the send_gen,
> it is considered a race and we yield. The code incrementing the
> s_send_lock_queue_raced statistics counter did not count this event
> correctly.
>
> This commit counts the race condition correctly.
>
> Changes from v1:
> - Removed check for *someone_on_xmit()*
> - Fixed incorrect indentation
>
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> Reviewed-by: Knut Omang <knut.omang@oracle.com>
Applied.
prev parent reply other threads:[~2017-09-08 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 16:35 Håkon Bugge
2017-09-06 16:48 ` Santosh Shilimkar
2017-09-08 3:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907.200733.1562967291105061977.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Haakon.Bugge@oracle.com \
--cc=knut.omang@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®