From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922AbdIGGgM (ORCPT ); Thu, 7 Sep 2017 02:36:12 -0400 Received: from mga11.intel.com ([192.55.52.93]:36856 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752783AbdIGGgL (ORCPT ); Thu, 7 Sep 2017 02:36:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,357,1500966000"; d="scan'208";a="1011878011" Date: Thu, 7 Sep 2017 09:36:07 +0300 From: Mika Westerberg To: Mario.Limonciello@dell.com Cc: yehezkel.bernat@intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, dvhart@infradead.org, hughsient@gmail.com Subject: Re: Fwd: [PATCH] Add driver to force WMI Thunderbolt controller power status Message-ID: <20170907063607.GB2477@lahna.fi.intel.com> References: <1504720440-24423-1-git-send-email-mario.limonciello@dell.com> <1504726863.2677.154.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 06, 2017 at 07:49:32PM +0000, Mario.Limonciello@dell.com wrote: > > As this is a Thunderbolt specific function, maybe it's better to be > > exposed from the Thunderbolt driver? > > I thought about this too, but the thunderbolt driver won't load if the > controller doesn't exist in the first place, whereas this is a platform > BIOS feature. I'll be interested to hear if Mika has a different perspective > on if this should live in the TBT driver and the proper way to do it. I think it makes sense to keep it separate from the Thunderbolt driver.