From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755428AbdIGNwP (ORCPT ); Thu, 7 Sep 2017 09:52:15 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59276 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755401AbdIGNwN (ORCPT ); Thu, 7 Sep 2017 09:52:13 -0400 From: Arnd Bergmann To: arm@kernel.org, Brian Norris , Gregory Fong , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Justin Chen , Gareth Powell , Doug Berger , linux-kernel@vger.kernel.org Subject: [PATCH] soc: bcm: brcmstb: fix ARM build errors Date: Thu, 7 Sep 2017 15:50:58 +0200 Message-Id: <20170907135136.2923775-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:whdiJGJbAr6W6LBuXV6IZ6CBRXtJSWEt7f0ivZ/Q/TSP21zwgSY ZMDxHJdmIpxz9ylxit7QM3YdAa+MyC2RDZAygncAz0Ag/DPRcPKtz/UxS2F4d8lizDO4ty0 zuyLjZ7BZtwYXM14jzbHsdyQt9o3mHybFpBS+DbKblcpHFCWlcOwEtUhC6ynxtoD5c9pwf1 zBWOFsnNVuM16LUpoxbyg== X-UI-Out-Filterresults: notjunk:1;V01:K0:lxzF6nITeuc=:FNrwboB2156E3t5/C8aUg4 1we/GeHcYAZZ24oGF1nPj47p2YXmO41cksopRhE8I3KEvW643M+WIRS72hNR7MKSKPuV3W7aw owzCmezVBVWTztR1Mq9CJX9VYLx20EzVUfHlprT52FFX7SrpfIY04PfY7W5w2VT3TaWBFU7ZE 6BZwE3naFcpP50SGbMGCEFuF0mMrB49cVfcOBDr4JwJbLaWu/CLB0V9wUyq8JBrzDBtBKN3BB KH7Ao64/pr8XxhRVBcAVXWr7EdnhJ4Dozv7+72izTYawT0KcG7KFgphizeTPK/r0MuNKZjJKB MNp5QQlj2nfbe8Q5bTgqDggGpz9g1k1K6h5pf7KtSjMQ41XiGRaDNw02Gw8sx+W8v5daTG52O nbHPDU4W8dbjXbzN/5gO+puM3LoS/kRTZUGSNqCIxV0qNHE3AITmQdPL/yh1CMDdvjFFzSA5h EBb2EG4Lrv+J7QnMBRbbnyyFAGggOR9a0ReWu8oCM0FlMyIG3DE7uSO+YyoJ15Mj7StrsNxt+ /8Co0s57Innq5514MwMSZoR9sv/YyrhwuPB2gye2Y7gCcPdxCb7k9nAUdet9BFl1XUR+K+6h5 dNwbY+hqnquXqKFT2FmN65dSqgZ7ik25JmgxJQw56jHJsjF1LqAEfO5ux4mO3UlGKyjiK+rNT FJfAOQERgC4ISL2uKV61EpZGeQIwHypSMbckFIe2knLqqE8kmlS266WvAPMJsJ5Z9R3rpwr39 npXNlijsTmcX9p8O5+EzxUKWXHuo+i1xRayH6w== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building the new PM driver on older ARM architectures, we can run into one of two build errors: drivers/soc/bcm/brcmstb/pm/pm-arm.c: In function 'brcmstb_do_pmsm_power_down': drivers/soc/bcm/brcmstb/pm/pm-arm.c:334:2: error: implicit declaration of function 'wfi' [-Werror=implicit-function-declaration] drivers/soc/bcm/brcmstb/pm/pm-arm.o: In function `brcmstb_pm_s3_finish': pm-arm.c:(.text+0x860): undefined reference to `cpu_resume' The first one requires at least ARMv6K, the second one requires the CPU suspend/resume logic which is not available on some of the older CPUs, and needs to be selected explicitly. This adds the extra Kconfig statements to enforce this, limiting compilation on ARM to the STB platform that is guaranteed to be ARMv7. We could enable compile-testing for other ARMv7 platforms, but there seems to be little value as an allmodconfig kernel already includes it. Acked-by: Florian Fainelli Signed-off-by: Arnd Bergmann --- drivers/soc/bcm/brcmstb/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/bcm/brcmstb/Kconfig b/drivers/soc/bcm/brcmstb/Kconfig index d05bfce82e71..d36f6e03c1a6 100644 --- a/drivers/soc/bcm/brcmstb/Kconfig +++ b/drivers/soc/bcm/brcmstb/Kconfig @@ -4,6 +4,7 @@ config BRCMSTB_PM bool "Support suspend/resume for STB platforms" default y depends on PM - depends on ARM || BMIPS_GENERIC + depends on ARCH_BRCMSTB || BMIPS_GENERIC + select ARM_CPU_SUSPEND if ARM endif # SOC_BRCMSTB -- 2.9.0