From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757438AbdIIDyP (ORCPT ); Fri, 8 Sep 2017 23:54:15 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42990 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753213AbdIIDyN (ORCPT ); Fri, 8 Sep 2017 23:54:13 -0400 Date: Fri, 08 Sep 2017 20:54:12 -0700 (PDT) Message-Id: <20170908.205412.2183497152163393093.davem@davemloft.net> To: keescook@chromium.org Cc: netdev@vger.kernel.org, jarod@redhat.com, gustavo@embeddedor.com, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: tulip: Constify tulip_tbl From: David Miller In-Reply-To: <20170907193514.GA114400@beast> References: <20170907193514.GA114400@beast> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Sep 2017 20:54:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook Date: Thu, 7 Sep 2017 12:35:14 -0700 > It looks like all users of tulip_tbl are reads, so mark this table > as read-only. > > $ git grep tulip_tbl # edited to avoid line-wraps... > interrupt.c: iowrite32(tulip_tbl[tp->chip_id].valid_intrs, ... > interrupt.c: iowrite32(tulip_tbl[tp->chip_id].valid_intrs&~RxPollInt, ... > interrupt.c: iowrite32(tulip_tbl[tp->chip_id].valid_intrs, ... > interrupt.c: iowrite32(tulip_tbl[tp->chip_id].valid_intrs | TimerInt, > pnic.c: iowrite32(tulip_tbl[tp->chip_id].valid_intrs, ioaddr + CSR7); > tulip.h: extern struct tulip_chip_table tulip_tbl[]; > tulip_core.c:struct tulip_chip_table tulip_tbl[] = { > tulip_core.c:iowrite32(tulip_tbl[tp->chip_id].valid_intrs, ioaddr + CSR5); > tulip_core.c:iowrite32(tulip_tbl[tp->chip_id].valid_intrs, ioaddr + CSR7); > tulip_core.c:setup_timer(&tp->timer, tulip_tbl[tp->chip_id].media_timer, > tulip_core.c:const char *chip_name = tulip_tbl[chip_idx].chip_name; > tulip_core.c:if (pci_resource_len (pdev, 0) < tulip_tbl[chip_idx].io_size) > tulip_core.c:ioaddr = pci_iomap(..., tulip_tbl[chip_idx].io_size); > tulip_core.c:tp->flags = tulip_tbl[chip_idx].flags; > tulip_core.c:setup_timer(&tp->timer, tulip_tbl[tp->chip_id].media_timer, > tulip_core.c:INIT_WORK(&tp->media_work, tulip_tbl[tp->chip_id].media_task); > > Cc: "David S. Miller" > Cc: Jarod Wilson > Cc: "Gustavo A. R. Silva" > Cc: netdev@vger.kernel.org > Cc: linux-parisc@vger.kernel.org > Signed-off-by: Kees Cook Applied.