From: Jan Glauber <jglauber@cavium.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
linux-kernel@vger.kernel.org, david.daney@cavium.com,
Jon Masters <jcm@redhat.com>,
Robert Richter <robert.richter@cavium.com>,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
Jan Glauber <jglauber@cavium.com>
Subject: [PATCH v4 3/3] PCI: Avoid slot reset if bus reset is not possible
Date: Fri, 8 Sep 2017 10:10:33 +0200 [thread overview]
Message-ID: <20170908081033.3025-4-jglauber@cavium.com> (raw)
In-Reply-To: <20170908081033.3025-1-jglauber@cavium.com>
When checking to see if a PCI slot can safely be reset, we check to
see if any of the children have their PCI_DEV_FLAGS_NO_BUS_RESET flag
set.
Some PCIe root port bridges do not behave well after a slot reset,
and may cause the device in the slot to become unusable.
Add a check for the PCI_DEV_FLAGS_NO_BUS_RESET flag being set in the
bridge device to prevent the slot from being reset.
Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
drivers/pci/pci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index b2a46ca7f133..45a086fc3592 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4393,6 +4393,10 @@ static bool pci_slot_resetable(struct pci_slot *slot)
{
struct pci_dev *dev;
+ if (slot->bus->self &&
+ (slot->bus->self->dev_flags & PCI_DEV_FLAGS_NO_BUS_RESET))
+ return false;
+
list_for_each_entry(dev, &slot->bus->devices, bus_list) {
if (!dev->slot || dev->slot != slot)
continue;
--
2.9.0.rc0.21.g7777322
next prev parent reply other threads:[~2017-09-08 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 8:10 [PATCH v4 0/3] Workaround for bus/slot reset on Cavium cn8xxx root ports Jan Glauber
2017-09-08 8:10 ` [PATCH v4 1/3] PCI: Allow PCI_DEV_FLAGS_NO_BUS_RESET to be used on bus device Jan Glauber
2017-09-08 8:10 ` [PATCH v4 2/3] PCI: Avoid bus reset for Cavium cn8xxx root ports Jan Glauber
2017-09-08 8:10 ` Jan Glauber [this message]
2017-09-12 9:40 ` [v4,0/3] Workaround for bus/slot reset on " Vadim Lomovtsev
2017-09-20 17:50 ` Jon Masters
2017-09-20 18:09 ` Alex Williamson
2017-09-21 8:06 ` Jan Glauber
2017-09-26 12:00 ` Jan Glauber
2017-10-11 15:33 ` [PATCH v4 0/3] " Robert Richter
2017-10-11 18:32 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908081033.3025-4-jglauber@cavium.com \
--to=jglauber@cavium.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=david.daney@cavium.com \
--cc=jcm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robert.richter@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®