From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756409AbdIHOlR (ORCPT ); Fri, 8 Sep 2017 10:41:17 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:32978 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756043AbdIHOlQ (ORCPT ); Fri, 8 Sep 2017 10:41:16 -0400 X-Google-Smtp-Source: AOwi7QB5GaclvscdcVZr5BJXIstNEttzfGZdY5AMW4Hrg0liCSv70DXfsrG6ixNlky9KtESY5ydflg== Date: Fri, 8 Sep 2017 07:41:12 -0700 From: Tejun Heo To: Shaohua Li Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, lizefan@huawei.com, tglx@linutronix.de, kernel-team@fb.com, axboe@kernel.dk, Shaohua Li Subject: Re: [PATCH 2/3] block: make blkcg aware of kthread stored original cgroup info Message-ID: <20170908144112.GZ1774378@devbig577.frc2.facebook.com> References: <6855d580111c20a6f147f3beec00fb593873608d.1504748195.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6855d580111c20a6f147f3beec00fb593873608d.1504748195.git.shli@fb.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Sep 06, 2017 at 07:00:52PM -0700, Shaohua Li wrote: > From: Shaohua Li > > Several blkcg APIs are deprecated. After removing them, bio_blkcg is the > only API to get cgroup info for a bio. If bio_blkcg finds current task > is a kthread and has original css recorded, it will use the css instead > of associating the bio to current task. Can you please separate out removal of unused APIs from modifications of existing ones? The patch is a bit confusing to follow. Thanks. -- tejun