From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757424AbdIIItx (ORCPT ); Sat, 9 Sep 2017 04:49:53 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:21804 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755689AbdIIItv (ORCPT ); Sat, 9 Sep 2017 04:49:51 -0400 Date: Sat, 9 Sep 2017 11:48:48 +0300 From: Dan Carpenter To: Badhri Jagan Sridharan Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , LKML , Guenter Roeck Subject: Re: [PATCH 2/2] staging: typec: tcpm: Only request matching pdos Message-ID: <20170908194155.4jp2jrwfdcf2b3wb@mwanda> References: <20170908012214.19047-1-Badhri@google.com> <20170908012214.19047-2-Badhri@google.com> <20170908093629.ob7fnaxlsbrmjksv@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 08, 2017 at 10:43:40AM -0700, Badhri Jagan Sridharan wrote: > >> /* > >> - * Select the source PDO providing the most power while staying within > >> - * the board's voltage limits. Prefer PDO providing exp > >> + * Select the source PDO providing the most power which has a > >> + * matchig sink cap. Prefer PDO providing exp > > ^^^^^^^ ^^^^^^^^^^^^^ > > "matching". What does "providing exp" mean? > > Actually that was moved forward from the existing code. > So not sure what that means ? I can remove it, if needed. > If I can't understand it, it probably means that I don't have any background knowledge, but if you can't understand it then probably no one can. :P Feel free to delete. regards, dan carpenter