From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757550AbdIIODN (ORCPT ); Sat, 9 Sep 2017 10:03:13 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33817 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753519AbdIIODL (ORCPT ); Sat, 9 Sep 2017 10:03:11 -0400 X-Google-Smtp-Source: ADKCNb5UJb3j5RQuzmDhAFEMsrG7G0nUSDTRxFQdp5aydan7dAhwttJokQbFQDik6WqXWiAmoBTBLA== Date: Sat, 9 Sep 2017 07:03:10 -0700 From: Guenter Roeck To: Greg Kroah-Hartman Cc: Badhri Jagan Sridharan , devel@driverdev.osuosl.org, LKML Subject: Re: [PATCH 1/2] staging: typec: tcpm: Validate source and sink caps Message-ID: <20170909140310.GB31517@roeck-us.net> References: <20170908012214.19047-1-Badhri@google.com> <20170908094559.GC2914@kroah.com> <20170908191325.GC19702@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170908191325.GC19702@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 08, 2017 at 09:13:25PM +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 08, 2017 at 10:29:52AM -0700, Badhri Jagan Sridharan wrote: > > On Fri, Sep 8, 2017 at 2:45 AM, Greg Kroah-Hartman > > wrote: > > > On Thu, Sep 07, 2017 at 06:22:13PM -0700, Badhri Jagan Sridharan wrote: > > >> The source and sink caps should follow the following rules. > > >> This patch validates whether the src_caps/snk_caps adheres > > >> to it. > > >> > > >> 6.4.1 Capabilities Message > > >> A Capabilities message (Source Capabilities message or Sink > > >> Capabilities message) shall have at least one Power > > >> Data Object for vSafe5V. The Capabilities message shall also > > >> contain the sending Port’s information followed by up to > > >> 6 additional Power Data Objects. Power Data Objects in a > > >> Capabilities message shall be sent in the following order: > > >> > > >> 1. The vSafe5V Fixed Supply Object shall always be the first object. > > >> 2. The remaining Fixed Supply Objects, if present, shall be sent > > >> in voltage order; lowest to highest. > > >> 3. The Battery Supply Objects, if present shall be sent in Minimum > > >> Voltage order; lowest to highest. > > >> 4. The Variable Supply (non-battery) Objects, if present, shall be > > >> sent in Minimum Voltage order; lowest to highest. > > >> > > >> Errors in source/sink_caps of the local port will prevent > > >> the port registration. Whereas, errors in source caps of partner > > >> device would only log them. > > >> > > >> Signed-off-by: Badhri Jagan Sridharan > > >> --- > > >> drivers/staging/typec/pd.h | 2 + > > >> drivers/staging/typec/tcpm.c | 107 +++++++++++++++++++++++++++++++++++++++---- > > >> drivers/staging/typec/tcpm.h | 16 +++---- > > >> 3 files changed, 108 insertions(+), 17 deletions(-) > > > > > > Before you add more stuff to this driver, what is needed to get it out > > > of staging? That would be more useful to do now, right? > > > > Actually not adding more features here. There was a bug where > > the phone wasnt charging at the highest possible power output, > > came up with the these patches while debugging that issue. > > Ok, but again, when is this going to get out of staging? Code wise nothing. Add documentation to data structures, eliminate dead code, drop and left over FIXME / TODO (those are not substantial enough to retain). Guenter