From: Jakub Kicinski <kubakici@wp.pl>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [bisected] Re: Module removal-related regression?
Date: Sat, 9 Sep 2017 22:17:26 +0200 [thread overview]
Message-ID: <20170909221726.241c29f6@cakuba.netronome.com> (raw)
In-Reply-To: <CAKdAkRTFFwNiFApsjy21qXipzZA4rme87fMkEYJYGQsEwPv5kg@mail.gmail.com>
On Sat, 9 Sep 2017 12:55:51 -0700, Dmitry Torokhov wrote:
> On Sat, Sep 9, 2017 at 12:27 PM, Jakub Kicinski <kubakici@wp.pl> wrote:
> > On Sat, 9 Sep 2017 19:41:21 +0200, Jakub Kicinski wrote:
> >> Hi!
> >>
> >> I'm having trouble with modules on linux/master. rmmod succeeds but the
> >> module is still loaded and the refcount goes to 1:
> >>
> >> #rmmod nfp; insmod ./src/nfp.ko nfp_pf_netdev=0 ; \
> >> /opt/netronome/bin/nfp-hwinfo -n 2 assembly.partno \
> >> lsmod | grep nfp; \
> >> rmmod nfp; \
> >> lsmod | grep nfp
> >> nfp 249856 0
> >> nfp 200704 1
> >>
> >> If I rmmod again the module will be actually unloaded. The user space
> >> is mostly Ubuntu 14.04. Has anyone seen this? I'm trying to bisect
> >> now...
> >
> > Got 'em!
> >
> > commit 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 (HEAD, refs/bisect/bad)
> > Author: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Date: Wed Jul 19 17:24:30 2017 -0700
> >
> > driver core: emit uevents when device is bound to a driver
>
> Does it happen with all modules or only nfp one?
>
> It seems to work here:
>
> dtor@dtor-glaptop3:~ $ lsmod | grep psmouse
> psmouse 135168 0
> dtor@dtor-glaptop3:~ $ sudo rmmod psmouse
> dtor@dtor-glaptop3:~ $ lsmod | grep psmouse
> dtor@dtor-glaptop3:~ $ sudo modprobe psmouse
It looks like the driver is actually reloaded. The driver used to
return EPROBE_DEFER, but I think it doesn't any more (rebuilding the
kernel to test that right now).
Could the uevent on unbind tickle Ubuntu 14.04's udev or somehow
else cause the driver to be loaded again?
next prev parent reply other threads:[~2017-09-09 20:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 17:41 Jakub Kicinski
2017-09-09 19:27 ` [bisected] " Jakub Kicinski
2017-09-09 19:55 ` Dmitry Torokhov
2017-09-09 20:10 ` Jakub Kicinski
2017-09-09 20:17 ` Jakub Kicinski [this message]
2017-09-09 20:59 ` Dmitry Torokhov
2017-09-09 22:03 ` Jakub Kicinski
2017-09-10 16:21 ` Dmitry Torokhov
2017-09-10 18:00 ` Jakub Kicinski
2017-09-10 18:12 ` Dmitry Torokhov
2017-09-10 18:39 ` Jakub Kicinski
2017-09-10 18:50 ` Dmitry Torokhov
2017-09-10 19:09 ` Greg Kroah-Hartman
2017-09-10 19:13 ` Jakub Kicinski
2017-09-10 21:22 ` Dmitry Torokhov
2017-09-11 15:23 ` Greg Kroah-Hartman
2017-09-11 18:29 ` Dmitry Torokhov
2017-09-12 12:00 ` Jakub Kicinski
2017-09-12 18:52 ` Dmitry Torokhov
2017-09-13 11:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170909221726.241c29f6@cakuba.netronome.com \
--to=kubakici@wp.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome