From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750936AbdIKFpQ (ORCPT ); Mon, 11 Sep 2017 01:45:16 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:44584 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbdIKFpO (ORCPT ); Mon, 11 Sep 2017 01:45:14 -0400 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Mon, 11 Sep 2017 14:44:57 +0900 From: Byungchul Park To: tj@kernel.org, johannes.berg@intel.com, peterz@infradead.org, mingo@kernel.org Cc: tglx@linutronix.de, oleg@redhat.com, david@fromorbit.com, linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: [PATCH v2 1/2] completion: Add support for initializing completion with lockdep_map Message-ID: <20170911054457.GE3240@X58A-UD3R> References: <1504860385-17371-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504860385-17371-1-git-send-email-byungchul.park@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 08, 2017 at 05:46:24PM +0900, Byungchul Park wrote: > To peter, > > Does it work? > > Chagnes from v1 > - Add a completion initialization function with a lockdep map > - Enhance readability of the workqueue code Do not you like it becasue it introduces another init_completion_xxx()? Anyway, I think the redundant acquisitions in the workqueue code should be removed. Right? > ----->8----- > >From e148617e20ebc9c9eefe7bb222b9bba07cb963bc Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Fri, 8 Sep 2017 17:39:48 +0900 > Subject: [PATCH v2 1/2] completion: Add support for initializing completion > with lockdep_map > > Sometimes, we want to initialize completions with sparate lockdep maps > to assign lock classes under control. For example, the workqueue code > manages lockdep maps, as it can classify lockdep maps properly. > Provided a function for that purpose. > > Signed-off-by: Byungchul Park > --- > include/linux/completion.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/completion.h b/include/linux/completion.h > index cae5400..182d56e 100644 > --- a/include/linux/completion.h > +++ b/include/linux/completion.h > @@ -49,6 +49,13 @@ static inline void complete_release_commit(struct completion *x) > lock_commit_crosslock((struct lockdep_map *)&x->map); > } > > +#define init_completion_with_map(x, m) \ > +do { \ > + lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \ > + (m)->name, (m)->key, 0); \ > + __init_completion(x); \ > +} while (0) > + > #define init_completion(x) \ > do { \ > static struct lock_class_key __key; \ > @@ -58,6 +65,7 @@ static inline void complete_release_commit(struct completion *x) > __init_completion(x); \ > } while (0) > #else > +#define init_completion_with_map(x, m) __init_completion(x) > #define init_completion(x) __init_completion(x) > static inline void complete_acquire(struct completion *x) {} > static inline void complete_release(struct completion *x) {} > -- > 1.9.1