mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Christos Gkekas <chris.gekas@gmail.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: Clean up dead code in root-tree
Date: Mon, 11 Sep 2017 19:06:18 +0200	[thread overview]
Message-ID: <20170911170618.GA14538@twin.jikos.cz> (raw)
In-Reply-To: <1504967374-14144-1-git-send-email-chris.gekas@gmail.com>

On Sat, Sep 09, 2017 at 03:29:34PM +0100, Christos Gkekas wrote:
> The value of variable 'can_recover' is never used after being set, thus
> it should be removed.

Seems it has never been used since introduction in commit
68a7342c51c95042 .

Reviewed-by: David Sterba <dsterba@suse.com>
> 
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
>  fs/btrfs/root-tree.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c
> index 95bcc3c..3338407 100644
> --- a/fs/btrfs/root-tree.c
> +++ b/fs/btrfs/root-tree.c
> @@ -226,10 +226,6 @@ int btrfs_find_orphan_roots(struct btrfs_fs_info *fs_info)
>  	struct btrfs_root *root;
>  	int err = 0;
>  	int ret;
> -	bool can_recover = true;
> -
> -	if (sb_rdonly(fs_info->sb))
> -		can_recover = false;
>  
>  	path = btrfs_alloc_path();
>  	if (!path)
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2017-09-11 17:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-09 14:29 Christos Gkekas
2017-09-11 17:06 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170911170618.GA14538@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=chris.gekas@gmail.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®