From: Benson Leung <bleung@google.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Olof Johansson <olof@lixom.net>,
Benson Leung <bleung@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
Brian Norris <computersforpeace@gmail.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Shawn Nematbakhsh <shawnn@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Enric Balletbo <enric.balletbo@collabora.co.uk>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v3] platform/chrome: Use proper protocol transfer function
Date: Mon, 11 Sep 2017 12:48:07 -0700 [thread overview]
Message-ID: <20170911194807.GA41615@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <20170908205011.77986-1-briannorris@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
Hi Brian,
On Fri, Sep 08, 2017 at 01:50:11PM -0700, Brian Norris wrote:
> From: Shawn Nematbakhsh <shawnn@chromium.org>
>
> pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had
> one instance of these functions correct, but not the second, fall-back
> case. We use the fall-back only when the first command returns an
> IN_PROGRESS status, which is only used on some EC firmwares where we
> don't want to constantly poll the bus, but instead back off and
> sleep/retry for a little while.
>
> Fixes: 2c7589af3c4d ("mfd: cros_ec: add proto v3 skeleton")
> Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Looks good. Applied for v4.14.
Thanks!
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-09-11 19:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 20:50 Brian Norris
2017-09-11 19:48 ` Benson Leung [this message]
2017-09-19 13:44 ` Jon Hunter
2017-09-19 14:09 ` Shawn N
2017-09-19 16:39 ` Jon Hunter
2017-09-19 17:03 ` Shawn N
2017-09-19 17:14 ` Brian Norris
2017-09-20 6:05 ` Shawn N
2017-09-20 6:13 ` Brian Norris
2017-09-20 20:22 ` Shawn N
2017-09-25 23:15 ` Shawn N
2017-09-26 15:40 ` Jon Hunter
2017-11-14 15:56 ` Jon Hunter
2017-11-14 15:59 ` Shawn N
2017-10-10 13:35 ` Jon Hunter
2017-10-10 15:33 ` Shawn N
2017-10-10 16:52 ` Doug Anderson
2017-11-07 11:28 ` Jon Hunter
2017-11-07 17:22 ` Doug Anderson
2017-11-08 10:20 ` Jon Hunter
2017-11-08 16:45 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911194807.GA41615@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.co.uk \
--cc=gwendal@chromium.org \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=shawnn@chromium.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome