From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751110AbdIKUBG (ORCPT ); Mon, 11 Sep 2017 16:01:06 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:55234 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbdIKUBF (ORCPT ); Mon, 11 Sep 2017 16:01:05 -0400 From: Arnd Bergmann To: Josh Poimboeuf , Ingo Molnar Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Kees Cook , linux-kernel@vger.kernel.org Subject: [PATCH] x86/kconfig: hide unwinder menu for KMEMCHECK Date: Mon, 11 Sep 2017 21:59:36 +0200 Message-Id: <20170911195950.3077184-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:s18ZVJSTkIQ5Cp9K+EYTm75FY9FsYXDmwffmHvZqdVT8bSIK83l WvSd0GrxJTpqxHQRZLy+htImG54Sc+vmJoFlf+pnGtqhGUFNz7ysKTUta5T5WZYtXopoqJN oWi2UH3w/njoNYO/fPO7qMtLtwHxY2VAaD7C1iaSmaFiCuk6yziydzuxUoZt1cq4qqHVbIy HXDtaYLzckE3+0jaOaN3g== X-UI-Out-Filterresults: notjunk:1;V01:K0:0nWIbVau9cQ=:LoArFVWO2Jae6n/WP5Vas5 bJF2QgZpTgOScUtyDufPwyRpXbuLWmlGIhlbjxvbpvHSq5u3ZBijnHUC245siXHDtxdl4Vkn9 us9EimW44QRRzwcxWnVjBgWm4pTDbGF3n+H4jQJROMKCi3tcbeOCnMBZMoeiXfRtBlmeXbiWu KhRyD/p0KprnKkXu5LAELpHlxwDYhMqNZ3pzYSUrIoDD3N+Qwoia+u5TlhrlTucm56GDV9EVA Z2jgn535JN//t28JAwDv1/QDdnZr4rOLN0Neg8JvXAwX1gtw55Nj8Bcbg6clpF+/ML92VYvm9 hQGxb7bejJQQIjJtyGIFrAmt6URxiqTpvs2m4S3KsWoH+5ePjNtwe25wAax8PqHhqnzk/upgz +UkIw0NRgvWTeWt/PKPNLEwQIjxJQ06ghXdeY2zA0dMxWanBPc1aDZYKJDE81qerA1B13hRdH 2KG+bKMuV4WBz/Hodi65hUpvpEpXNx/zMn+8I8OKSfpySQnxfldYsWu1haylGb/e8uQ5FLfsr EbFWQ9F+rGzBjyg1D8R1tUXkUQU6JqsfTx1r0tVl/EB/S5IG4TD31LGKMW6u54cUR6+VPMSkr S2y5VHZxmToNx0SW7jM7x2u9KTTmbuMPQvtFnfRrx6kFobm949AUabHfZeGcNme4eLiiSDx4X CIZcA+/9tFH0pka4FEXrFgyuqWenDWSh3qml9xzmrKRG8NCPCtOj4JwIXHlJ2B3fKhZ1vvuVT yNW5vuneRy9Jng/7scQW74ceJvqGP/LIeLHqYw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When KMEMCHECK is enabled, we always build with frame pointers, which is incompatible with ORC_UNWINDER and GUESS_UNWINDER, as Kconfig points out: warning: (FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && KMEMCHECK && LOCKDEP && FRAME_POINTER_UNWINDER) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || SUPERH || BLACKFIN || MN10300 || METAG) || ARCH_WANT_FRAME_POINTERS || !ORC_UNWINDER && !GUESS_UNWINDER) This works around it by making those two unwinders depend on !KMEMCHECK. The other three options that enable frame pointers (FAULT_INJECTION_STACKTRACE_FILTER, LATENCYTOP and LOCKDEP) only do that on some architectures but not on x86. It's possible that KMEMCHECK doesn't actually require frame pointers but only requires some unwinder. If that is the case, we should drop the 'select FRAME_POINTER' there. KMEMCHECK is currenly used only on x86. Fixes: 81d387190039 ("x86/kconfig: Consolidate unwinders into multiple choice selection") Signed-off-by: Arnd Bergmann --- arch/x86/Kconfig.debug | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index 71a48a30fc84..79f0f563d525 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug @@ -381,7 +381,7 @@ config FRAME_POINTER_UNWINDER config ORC_UNWINDER bool "ORC unwinder" - depends on X86_64 + depends on X86_64 && !KMEMCHECK select STACK_VALIDATION ---help--- This option enables the ORC (Oops Rewind Capability) unwinder for @@ -397,7 +397,7 @@ config ORC_UNWINDER config GUESS_UNWINDER bool "Guess unwinder" - depends on EXPERT + depends on EXPERT && !KMEMCHECK ---help--- This option enables the "guess" unwinder for unwinding kernel stack traces. It scans the stack and reports every kernel text address it -- 2.9.0