mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benson Leung <bleung@google.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, bleung@google.com
Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup
Date: Mon, 11 Sep 2017 16:29:07 -0700	[thread overview]
Message-ID: <20170911232907.GA92445@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <20170911200252.GB41615@decatoncale.mtv.corp.google.com>

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

Hi Oliver,

On Mon, Sep 11, 2017 at 01:02:52PM -0700, Benson Leung wrote:
> Thanks for the pointer. I'll respin the patch with the no_resume version of
> usb_autopm_get_interface and retest.
> 

I went and tried this patch but with usb_autopm_get_interface_no_resume instead
and the original bug I was trying to fix with a Yubikey hid security key came
back, so something is still wrong here.

I went ahead and filed a bug to track this here:
https://bugs.chromium.org/p/chromium/issues/detail?id=764112

I'll find some time to dig into this deeper and understand why this device
ends up getting stuck in active instead of suspending when all handles are
closed.

Thanks,
Benson

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-09-11 23:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08 17:43 Dmitry Torokhov
2017-09-09  7:35 ` Oliver Neukum
2017-09-11 20:02   ` Benson Leung
2017-09-11 23:29     ` Benson Leung [this message]
2017-09-20  1:39       ` Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2014-11-13 20:16 Benson Leung
2014-11-13 20:41 ` Alan Stern
2014-11-13 20:44   ` Benson Leung
2014-11-13 21:18     ` Alan Stern
2014-11-13 21:41       ` Benson Leung
2014-11-13 22:11         ` Alan Stern
2014-11-13 22:15           ` Benson Leung
2014-11-14 15:17             ` Alan Stern
2014-11-22  0:44               ` Benson Leung
2014-11-22 15:55                 ` Alan Stern
2014-11-22 16:02                   ` Alan Stern
2014-11-25  1:29                   ` Benson Leung
2014-11-25 15:24                     ` Alan Stern
2014-11-25 15:29                       ` Benson Leung
2014-11-14  9:08 ` Oliver Neukum
2014-11-22  1:00   ` Benson Leung
2014-11-24  9:13     ` Oliver Neukum
2014-11-25  0:56       ` Benson Leung
2014-11-25  9:53         ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170911232907.GA92445@decatoncale.mtv.corp.google.com \
    --to=bleung@google.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=bleung@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=groeck@chromium.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome