From: Dave Young <dyoung@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
bauerman@linux.vnet.ibm.com, dhowells@redhat.com,
vgoyal@redhat.com, herbert@gondor.apana.org.au,
davem@davemloft.net, akpm@linux-foundation.org,
mpe@ellerman.id.au, bhe@redhat.com, arnd@arndb.de,
ard.biesheuvel@linaro.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/9] kexec_file: factor out crashdump elf header function from x86
Date: Tue, 12 Sep 2017 13:55:21 +0800 [thread overview]
Message-ID: <20170912055521.GA8787@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20170908031616.17916-4-takahiro.akashi@linaro.org>
Hi,
On 09/08/17 at 12:16pm, AKASHI Takahiro wrote:
[snip]
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -162,6 +162,25 @@ int __weak arch_kexec_walk_mem(struct kexec_buf *kbuf,
> int (*func)(u64, u64, void *));
> extern int kexec_add_buffer(struct kexec_buf *kbuf);
> int kexec_locate_mem_hole(struct kexec_buf *kbuf);
> +#ifdef CONFIG_CRASH_CORE
> +extern int prepare_elf_headers(struct kimage *image, void **addr,
> + unsigned long *sz);
> +
> +/* This primarily represents number of split ranges due to exclusion */
> +#define CRASH_MAX_RANGES 16
> +
> +struct crash_mem_range {
> + u64 start, end;
> +};
> +
> +struct crash_mem {
> + unsigned int nr_ranges;
> + struct crash_mem_range ranges[CRASH_MAX_RANGES];
> +};
> +
> +extern int exclude_mem_range(struct crash_mem *mem,
> + unsigned long long mstart, unsigned long long mend);
> +#endif /* CONFIG_CRASH_CORE */
Maybe I did not say it clear when reviewing the v1.
I suggested to move the code from to kexec_file.c because the
CONFIG_CRASH_CORE originally was introduced for the common code for
vmcoreinfo stuff when Hari worked on sharing code between powerpc
fadump and kdump.
I'm not sure we need the #ifdef CONFIG_CRASH_CORE here for these
kexec file load functions. Since they are already in kexec_file.c
so I think no need to add the #ifdef
> #endif /* CONFIG_KEXEC_FILE */
Thanks
Dave
next prev parent reply other threads:[~2017-09-12 5:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 3:16 [PATCH 0/9] kexec: add kexec_file_load() support AKASHI Takahiro
2017-09-08 3:16 ` [PATCH 1/9] include: pe.h: remove message[] from mz header definition AKASHI Takahiro
2017-09-08 3:16 ` [PATCH 2/9] resource: add walk_system_ram_res_rev() AKASHI Takahiro
2017-09-08 3:16 ` [PATCH 3/9] kexec_file: factor out crashdump elf header function from x86 AKASHI Takahiro
2017-09-12 5:55 ` Dave Young [this message]
2017-09-13 0:46 ` AKASHI Takahiro
2017-09-08 3:16 ` [PATCH 4/9] asm-generic: add kexec_file_load system call to unistd.h AKASHI Takahiro
2017-09-08 3:16 ` [PATCH 5/9] arm64: kexec_file: create purgatory AKASHI Takahiro
2017-09-08 3:16 ` [PATCH 6/9] arm64: kexec_file: load initrd, device-tree and purgatory segments AKASHI Takahiro
2017-09-11 6:47 ` Dave Young
2017-09-11 8:25 ` Dave Young
2017-09-12 4:46 ` AKASHI Takahiro
2017-09-08 3:16 ` [PATCH 7/9] arm64: kexec_file: set up for crash dump adding elf core header AKASHI Takahiro
2017-09-08 3:16 ` [PATCH 8/9] arm64: enable KEXEC_FILE config AKASHI Takahiro
2017-09-10 15:41 ` kbuild test robot
2017-09-12 4:43 ` AKASHI Takahiro
2017-09-08 3:16 ` [PATCH 9/9] arm64: kexec_file: add Image format support AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912055521.GA8787@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bauerman@linux.vnet.ibm.com \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=takahiro.akashi@linaro.org \
--cc=vgoyal@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®