From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751364AbdILGFC (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Sep 2017 02:05:02 -0400
Received: from mail-pf0-f172.google.com ([209.85.192.172]:35020 "EHLO
        mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751195AbdILGFA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Sep 2017 02:05:00 -0400
X-Google-Smtp-Source: ADKCNb7juR5Tvj/sSgGDZuX8L6quiK8Tb24QbbzsmH5H6uDD2htw6BKNF3Y07VEujFm3szXY5KJRuw==
Date: Tue, 12 Sep 2017 15:04:56 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, kernel-team <kernel-team@lge.com>,
        Ilya Dryomov <idryomov@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Ross Zwisler <ross.zwisler@linux.intel.com>,
        Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH 5/5] mm:swap: skip swapcache for swapin of synchronous
 device
Message-ID: <20170912060456.GA703@jagdpanzerIV.localdomain>
References: <1505183833-4739-1-git-send-email-minchan@kernel.org>
 <1505183833-4739-5-git-send-email-minchan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1505183833-4739-5-git-send-email-minchan@kernel.org>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (09/12/17 11:37), Minchan Kim wrote:
> +		} else {
> +			/* skip swapcache */
> +			page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->address);

what if alloc_page_vma() fails?

> +			__SetPageLocked(page);
> +			__SetPageSwapBacked(page);
> +			set_page_private(page, entry.val);
> +			lru_cache_add_anon(page);
> +			swap_readpage(page, true);
> +		}

	-ss