From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbdILHky (ORCPT ); Tue, 12 Sep 2017 03:40:54 -0400 Received: from mga11.intel.com ([192.55.52.93]:1127 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbdILHkw (ORCPT ); Tue, 12 Sep 2017 03:40:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,382,1500966000"; d="scan'208";a="899391642" Date: Tue, 12 Sep 2017 10:38:39 +0300 From: Heikki Krogerus To: Guenter Roeck Cc: Greg Kroah-Hartman , Yueyao Zhu , Badhri Jagan Sridharan , Hans de Goede , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code Message-ID: <20170912073839.GA18391@kuha.fi.intel.com> References: <1505187128-5459-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505187128-5459-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote: > Commented out code can be added as needed. Drop it. > Also drop TODO and an obsolete XXX comment. > > Signed-off-by: Guenter Roeck > --- > v2, v3: No change > > drivers/staging/typec/tcpm.c | 37 +------------------------------------ > 1 file changed, 1 insertion(+), 36 deletions(-) Nice! Just to be sure: The idea is to leave tcpci.c in staging, right? In any case, FWIW, for all of these: Acked-by: Heikki Krogerus -- heikki