From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751541AbdILUIs (ORCPT ); Tue, 12 Sep 2017 16:08:48 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:54712 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbdILUIr (ORCPT ); Tue, 12 Sep 2017 16:08:47 -0400 From: Arnd Bergmann To: Thomas Gleixner , Jason Cooper , Marc Zyngier Cc: Arnd Bergmann , Eric Auger , linux-kernel@vger.kernel.org Subject: [PATCH] irqchip/gic-v4: fix building with ancient gcc Date: Tue, 12 Sep 2017 22:08:23 +0200 Message-Id: <20170912200832.3609124-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:mEvKN6aXQN1G7lH90Yjvy2IDGHA4hlMUozDYVCWdx1O5Bm9pvX9 Dq59XoAwtI2eoBmEoglC7B99l50djBrs+gshkcnjUurScodS0Bt4CVCKm9+J3sdJ2ZinRz8 nBn0rNx3XDKO3ZbaUidC1iJbA2G7oPc7JPblJgxPasL01mbgSMVHhsRJChQVOoOpHgbnVjg WWcCktpJOXdKWTyJX5O9g== X-UI-Out-Filterresults: notjunk:1;V01:K0:6RDGwGPwe24=:ScKQLdLhm9/owh1GJC/Rct BIEwBkNGbGJo1w5D0KEM1EZDjNr5MXncBM1rkv+9bGVKuqGv3CNDgRjq7QA7mVn0QXoUncugA S8rrvIubPfDkHxV78mZxRupE65iKdag+/4xIaPjXOEt9u4oKemx6H1+upuDxB11Q6WTrbJaFe UACpDSJV+GNsP6jwvlorYsIcWMBBeAXd9oIM+9cAaPEVmLmMtNJnxIzeHTPjskjIuVmU2DGWK l9xjrnqcgB/CyOXo2UavE3q/rO4qAkHujkxJ8Nba2iNrzAV1HVaAv4FOy530aGUwsp8U2JBNQ Aq1iHoTUcJR496QNfeQKlUZpdveSN+4HfT26X13n7DMsiWl6g9c1j9UBxwUB1r4o7h6tsyPbn Hc/Aj9mgRB8ux24YZizjWhMnnG5hbRpoChzdjxJKnJLNkFdDPzTtSO4cM37yRjivbwH7+SxOI UcjPKiT6ilOHs4v97kBaB3+P+/dFloKv/SnMYVQhj0lYIAehs1J8SaFLg6IZZekY62AtElRJR Rj6aF4OruzXBXjGSR/FoJNarTMcz+L/Vw6YVeyvB6rjEQ6Rv27Ysb1dBe7BDM7+sxkbxoaS2D KTYBgmEeQtpvObvUf45r8E/hBYc/l4rHUHQrE7ppwuvz5/p5YGCbKhM4qnd4we+7EIFukM15v 9+DMwRqx4NMvHcTU3W/qv6IOGdNwCkRI09Yj4Rr6fluyOY4eQoq7qU2fpnw7m1xPSlmvLxbGU YgWR2M6zXqQdmLfzGKE2HL2F/oXUDoUpUNmZyQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-4.5 and earlier don't like named initializers for anonymous union members: drivers/irqchip/irq-gic-v4.c: In function 'its_map_vlpi': drivers/irqchip/irq-gic-v4.c:176:3: error: unknown field 'map' specified in initializer drivers/irqchip/irq-gic-v4.c:176:3: error: missing braces around initializer drivers/irqchip/irq-gic-v4.c:176:3: error: (near initialization for 'info.') drivers/irqchip/irq-gic-v4.c: In function 'its_get_vlpi': drivers/irqchip/irq-gic-v4.c:192:3: error: unknown field 'map' specified in initializer drivers/irqchip/irq-gic-v4.c:192:3: error: missing braces around initializer drivers/irqchip/irq-gic-v4.c:192:3: error: (near initialization for 'info.') drivers/irqchip/irq-gic-v4.c: In function 'its_prop_update_vlpi': drivers/irqchip/irq-gic-v4.c:208:3: error: unknown field 'config' specified in initializer drivers/irqchip/irq-gic-v4.c:208:3: error: missing braces around initializer drivers/irqchip/irq-gic-v4.c:208:3: error: (near initialization for 'info.') drivers/irqchip/irq-gic-v4.c:208:3: error: initialization makes pointer from integer without a cast This is fairly easy to work around, by using extra curly braces. Signed-off-by: Arnd Bergmann --- drivers/irqchip/irq-gic-v4.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-gic-v4.c b/drivers/irqchip/irq-gic-v4.c index 2370e6d9e603..cd0bcc3b7e33 100644 --- a/drivers/irqchip/irq-gic-v4.c +++ b/drivers/irqchip/irq-gic-v4.c @@ -173,7 +173,9 @@ int its_map_vlpi(int irq, struct its_vlpi_map *map) { struct its_cmd_info info = { .cmd_type = MAP_VLPI, - .map = map, + { + .map = map, + }, }; /* @@ -189,7 +191,9 @@ int its_get_vlpi(int irq, struct its_vlpi_map *map) { struct its_cmd_info info = { .cmd_type = GET_VLPI, - .map = map, + { + .map = map, + }, }; return irq_set_vcpu_affinity(irq, &info); @@ -205,7 +209,9 @@ int its_prop_update_vlpi(int irq, u8 config, bool inv) { struct its_cmd_info info = { .cmd_type = inv ? PROP_UPDATE_AND_INV_VLPI : PROP_UPDATE_VLPI, - .config = config, + { + .config = config, + }, }; return irq_set_vcpu_affinity(irq, &info); -- 2.9.0