From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616AbdILUJm (ORCPT ); Tue, 12 Sep 2017 16:09:42 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:59252 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbdILUJj (ORCPT ); Tue, 12 Sep 2017 16:09:39 -0400 From: Arnd Bergmann To: Sylwester Nawrocki , Mauro Carvalho Chehab Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [media] s3c-camif: fix out-of-bounds array access Date: Tue, 12 Sep 2017 22:09:18 +0200 Message-Id: <20170912200932.3634089-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:7Y2H/kfNC81X9jnQ7yY2GZrWCNkfP41R2oNj5IHtNlAZaNGAdE8 1DrHoRJC44CNw0TwR41ap9aJPEtA/kSEdS+sRZdwARSEWdOemMfZEOOBs9gSExYPM893GsS 2XOKZ/FnkiCsmsGZhwH8b+A71LQ6dZmv6/ULEsMLEcPxCatCOpBzTFX/p6K85smRiaiwljV Zy4USPrkaV3k5UJvT2bog== X-UI-Out-Filterresults: notjunk:1;V01:K0:oZGdtugrh0g=:5JbJkd8hGa0RuILAIwZR1B zwo3f5WNe52n6TVKJ42Y8YOiKq/WsRABSXUMsf5thryZCrVLg/Zf/76FCSL7/7Zvj5Y5AEo76 IvHWKSZrpamTj7vUgPEUueu6cOLLIeURZ8cmrPBKtBNClGRA0LrzJdut6zPqdo6xGO28tgUKO yupmiEcyXwZ7JdtXMrg1mCTqwmGH3iJ2aZ/gJ9ZpQipdnuMvmjb4wo8OmZTOT9bKSw2t4FGmn OWhpvFyel4iD9EvORK1+dZweHDWzMW0GJF8s54EJDSdmlXZy5vWJkWTjv4xsufbCvot/0nypY i1G8VKcN1WB1+GphGd/dmyh8vwRwOr1+hAolKOUlVGWiD9CywuLYYeVPUAS8sw9SGH4ty99NJ Sk3LnqMtGE48Fu9E/LyJUXjYnqA960zWrW1yYHkDurk9QPXsWrBl+8Pc7pQWtHSFy2BCFO367 xxEwR7cb73GPDOL/xk0Czt8MjFxSr5nRm+3XEnbmy8dylXn+3thaNaZpZ4wI8UIW72eGaPKcK 1mopu2a56sggjxHVS5pLgJHLFL1Vl8nuvyRJyYJusrK/IgMmG+C1KKPhUMFYOTnCTmWwrKzGx WYJhIgGDXWkF8LZFeGPCKvxzdJpEBQcAFRKDZS7asL3ec2nrzQiREOXfzupOh5XU/sQGXnTCQ Mkk9HaPjr11XaqEJlDL3CF1mz94s2z4d+KeIT0zCuh355wRI2LChQ0dBanbYlTTZoM+1c6lzI CNyPhaiDnidNAr8OMiKkKex+Ha9lYdhE/SiAsw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While experimenting with older compiler versions, I ran into a warning that no longer shows up on gcc-4.8 or newer: drivers/media/platform/s3c-camif/camif-capture.c: In function '__camif_subdev_try_format': drivers/media/platform/s3c-camif/camif-capture.c:1265:25: error: array subscript is below array bounds This is an off-by-one bug, leading to an access before the start of the array, while newer compilers silently assume this undefined behavior cannot happen and leave the loop at index 0 if no other entry matches. Since the code is not only wrong, but also has no effect besides the out-of-bounds access, this patch just removes it. I found an existing gcc bug for it and added a reduced version of the function there. Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69249#c3 Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") Signed-off-by: Arnd Bergmann --- drivers/media/platform/s3c-camif/camif-capture.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/media/platform/s3c-camif/camif-capture.c b/drivers/media/platform/s3c-camif/camif-capture.c index 25c7a7d42292..c6921f6a5a6a 100644 --- a/drivers/media/platform/s3c-camif/camif-capture.c +++ b/drivers/media/platform/s3c-camif/camif-capture.c @@ -1256,17 +1256,10 @@ static void __camif_subdev_try_format(struct camif_dev *camif, { const struct s3c_camif_variant *variant = camif->variant; const struct vp_pix_limits *pix_lim; - int i = ARRAY_SIZE(camif_mbus_formats); /* FIXME: constraints against codec or preview path ? */ pix_lim = &variant->vp_pix_limits[VP_CODEC]; - while (i-- >= 0) - if (camif_mbus_formats[i] == mf->code) - break; - - mf->code = camif_mbus_formats[i]; - if (pad == CAMIF_SD_PAD_SINK) { v4l_bound_align_image(&mf->width, 8, CAMIF_MAX_PIX_WIDTH, ffs(pix_lim->out_width_align) - 1, -- 2.9.0