From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751752AbdILULZ (ORCPT ); Tue, 12 Sep 2017 16:11:25 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:56502 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbdILULV (ORCPT ); Tue, 12 Sep 2017 16:11:21 -0400 From: Arnd Bergmann To: David Ahern , Shrijeet Mukherjee Cc: Arnd Bergmann , "David S. Miller" , Julian Anastasov , Matthias Schiffer , Wei Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: vrf: avoid gcc-4.6 warning Date: Tue, 12 Sep 2017 22:10:53 +0200 Message-Id: <20170912201100.3680915-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:KHrgLJ62MRueR7RXhu+tEHGgLFeVw2ZQIiL9E6rcg4qWQCtDfwR 0LSLeTHrSWIlpuKsr+yq+z9S/3Yybl7sAOZVq8bRF5mASrBqCn99YRpM3FHPt34957Ct/f+ 6avfdkIYKVxZ+pO0UIKGtNfHtHi1VxCmgMXiSy79uhJ7cBMCfpsYKDndck6R08gTd07EbcS SVsj5LHzxxuuQ7XvKFRAw== X-UI-Out-Filterresults: notjunk:1;V01:K0:EucAqCoaf+k=:OEnogRyJKQKQ7Wng8rLNfQ cWSa6phc9bFtUXK0LsI9V5lWUTjO7LS3Nq3CLyDlgcaEuFbvZURxBL49hfZQwJ/Bi+apgdBFc 1cBmULIrJH9cJz0YCLXDU5Uq61/IDc97I+HZW1+c+a8IpeGxnydIvBKQXCclbK5nH29cy4e9M blOXKV+rhPOP506OxhX2uDfnspsJS9kHZ0XmUPnq+aqRbhVd9Ik6o5ZPi+Im/RXxJbxee9Dmt QlWpepn/FXEj7AfQAf2zRrv+ydR/s6aMIaAopeQl5UwjW8iOC/oE/5sQfs/AIwQSg/IhpwAnR LWVdLg2t0/azjw5pWuOqZE/Y6MQA8zcbB2E3sSGGdej07q4ba0yKHjXUV877KBGhUvwbF+pA0 OcKcNw9kbFex+G7cs1W7lhy8965VWRbUHDJjkkk8lLsCbvtuYDODSh7+oyIamgwSuRlpylahu Wbn/scJPPRl6FB7GmaHGelj//ttk2wVD8QIsqHBi0VuEy8ko4b6ykBmhoYY3srbAkdSzgO9O7 RUjjf/IXXlP1MeSFij/linOQBrfQs79sCzT1FVlQsOBf418ELUiCw9p9t+Tu65C7lfLGOFRJA ok5k4Lk2KQq77UiE+jOCmOG7Jr7W0EcMZgpcw5CcmIUPCg1uCKVUi1/8OJIxQan6QV3GO9T1F ONbQXa77p/UDQH3v0D6UVBJE4CMLDJzn8Hb0GC4fo7vjOZ38uRbS/pjqbsaIb4FwG2axozZ91 p0hgbhMoit9+1g/jOz464czaDCJ1Sph+TsjOfGWKdQ5B9TqITWnP3gk28qc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building an allmodconfig kernel with gcc-4.6, we get a rather odd warning: drivers/net/vrf.c: In function ‘vrf_ip6_input_dst’: drivers/net/vrf.c:964:3: error: initialized field with side-effects overwritten [-Werror] drivers/net/vrf.c:964:3: error: (near initialization for ‘fl6’) [-Werror] I have no idea what this warning is even trying to say, but it does seem like a false positive. Reordering the initialization in to match the structure definition gets rid of the warning, and might also avoid whatever gcc thinks is wrong here. Fixes: 9ff74384600a ("net: vrf: Handle ipv6 multicast and link-local addresses") Signed-off-by: Arnd Bergmann --- drivers/net/vrf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 7e19051f3230..9b243e6f3008 100644 --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -957,12 +957,12 @@ static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device *vrf_dev, { const struct ipv6hdr *iph = ipv6_hdr(skb); struct flowi6 fl6 = { + .flowi6_iif = ifindex, + .flowi6_mark = skb->mark, + .flowi6_proto = iph->nexthdr, .daddr = iph->daddr, .saddr = iph->saddr, .flowlabel = ip6_flowinfo(iph), - .flowi6_mark = skb->mark, - .flowi6_proto = iph->nexthdr, - .flowi6_iif = ifindex, }; struct net *net = dev_net(vrf_dev); struct rt6_info *rt6; -- 2.9.0