From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522AbdIMQUk (ORCPT ); Wed, 13 Sep 2017 12:20:40 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:51360 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662AbdIMQUi (ORCPT ); Wed, 13 Sep 2017 12:20:38 -0400 Date: Wed, 13 Sep 2017 09:20:31 -0700 (PDT) Message-Id: <20170913.092031.2176431746672254970.davem@davemloft.net> To: allen.lkml@gmail.com Cc: linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, megaraidlinux.pdl@broadcom.com, target-devel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. From: David Miller In-Reply-To: <1505287939-14106-6-git-send-email-allen.lkml@gmail.com> References: <1505287939-14106-1-git-send-email-allen.lkml@gmail.com> <1505287939-14106-6-git-send-email-allen.lkml@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Sep 2017 09:20:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Allen Pais Date: Wed, 13 Sep 2017 13:02:15 +0530 > Signed-off-by: Allen Pais This is quite pointless as the caller doesn't do anything with the value, it just tests whether a negative value is returned or not.