From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751821AbdIMHQu (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Sep 2017 03:16:50 -0400
Received: from mail-pg0-f66.google.com ([74.125.83.66]:35719 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751012AbdIMHQp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Sep 2017 03:16:45 -0400
X-Google-Smtp-Source: ADKCNb4Dookw9L20N+ZDl2sUpjj9xUaSomJK8VXLV21FTfdseuiufTnCpkhvh6gY7BGbQsFX8RS5HQ==
Date: Wed, 13 Sep 2017 16:16:39 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH 2/2] zram: remove zlib from the list of recommended
 algorithms
Message-ID: <20170913071637.GA602@jagdpanzerIV.localdomain>
References: <20170912050005.3247-1-sergey.senozhatsky@gmail.com>
 <20170912050005.3247-2-sergey.senozhatsky@gmail.com>
 <20170913071246.GB2975@bbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170913071246.GB2975@bbox>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (09/13/17 16:12), Minchan Kim wrote:
> On Tue, Sep 12, 2017 at 02:00:05PM +0900, Sergey Senozhatsky wrote:
> > ZSTD tends to outperform deflate/inflate, thus we remove
> > zlib from the list of recommended algorithms and recommend
> > zstd instead.
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Suggested-by: Minchan Kim <minchan@kernel.org>
>  
> I did test with my sample data and compared zstd with deflate.
> zstd's compress ratio is lower a little bit but compression
> speed is much faster 3 times more and decompress speed is too
> 2 times more. With different data, it is different but overall,
> zstd would be better for speed at the cost of a little lower compress
> ratio(about 5%) so I believe it's worth to replace deflate.

hm, interesting. on my "real world" use-cases zstd has better
compression ratio.

> Thanks for the patch, Sergey.
> 
> Acked-by: Minchan Kim <minchan@kernel.org>

thanks.

	-ss