From: Dan Carpenter <dan.carpenter@oracle.com>
To: Allen Pais <allen.lkml@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, mchehab@kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array
Date: Wed, 13 Sep 2017 11:22:11 +0300 [thread overview]
Message-ID: <20170913082211.2btqdehfq7co4mtx@mwanda> (raw)
In-Reply-To: <1505289879-26163-1-git-send-email-allen.lkml@gmail.com>
You need a changelog.
On Wed, Sep 13, 2017 at 01:34:39PM +0530, Allen Pais wrote:
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
> index e882b55..d822918 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
> @@ -451,7 +451,7 @@ static enum ia_css_frame_format yuv422_copy_formats[] = {
> IA_CSS_FRAME_FORMAT_YUYV
> };
>
> -#define array_length(array) (sizeof(array)/sizeof(array[0]))
> +#define array_length(array) (ARRAY_SIZE(array))
Just get rid of this array_length macro and use ARRAY_SIZE() directly.
regards,
dan carpenter
next prev parent reply other threads:[~2017-09-13 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 8:04 Allen Pais
2017-09-13 8:22 ` Dan Carpenter [this message]
2017-09-13 8:39 ` Allen
2017-09-13 8:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913082211.2btqdehfq7co4mtx@mwanda \
--to=dan.carpenter@oracle.com \
--cc=allen.lkml@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®