From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752235AbdIMLSt (ORCPT ); Wed, 13 Sep 2017 07:18:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:55146 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751148AbdIMLSq (ORCPT ); Wed, 13 Sep 2017 07:18:46 -0400 Date: Wed, 13 Sep 2017 13:18:43 +0200 From: Michal Hocko To: Gi-Oh Kim Cc: "linux-kernel@vger.kernel.org" , linux-mm@kvack.org Subject: Re: [PATCH] mm/memblock.c: make the index explicit argument of for_each_memblock_type Message-ID: <20170913111843.2kt344k7pmcmm2ed@dhcp22.suse.cz> References: <20170913090606.16412-1-gi-oh.kim@profitbricks.com> <20170913105539.ijfwfrfbn3bici6g@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 13-09-17 13:05:02, Gi-Oh Kim wrote: > On Wed, Sep 13, 2017 at 12:55 PM, Michal Hocko wrote: > > On Wed 13-09-17 11:06:06, Gioh Kim wrote: > >> for_each_memblock_type macro function uses idx variable that is > >> the local variable of caller. This patch makes for_each_memblock_type > >> use only its own arguments. > > > > strictly speaking this changelog doesn't explain _why_ the original code > > is wrong/suboptimal and why you are changing that. I would use the > > folloging > > > > " > > for_each_memblock_type macro function relies on idx variable defined in > > the caller context. Silent macro arguments are almost always wrong thing > > to do. They make code harder to read and easier to get wrong. Let's > > use an explicit iterator parameter for for_each_memblock_type and make > > the code more obious. This patch is a mere cleanup and it shouldn't > > introduce any functional change. > > " > > Absolutely this changelog is better. > Should I send the patch with your changelog again? > Or could you just replace my changelog with yours? Please repost and make sure to CC Andrew Morton so that he can take the patch. -- Michal Hocko SUSE Labs