From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbdIMSwu (ORCPT ); Wed, 13 Sep 2017 14:52:50 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40484 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751881AbdIMSwt (ORCPT ); Wed, 13 Sep 2017 14:52:49 -0400 From: Martin Kepplinger To: jpoimboe@redhat.com Cc: linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [PATCH] tools: objtool: fix memory leak in elf_create_rela_section() Date: Wed, 13 Sep 2017 20:52:38 +0200 Message-Id: <20170913185238.26162-1-martink@posteo.de> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's free the allocated char array relaname before returning in order to avoid leaking memory. Signed-off-by: Martin Kepplinger --- tools/objtool/elf.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6e9f980a7d26..6aacbc31316d 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base) strcat(relaname, base->name); sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0); - if (!sec) + if (!sec) { + free(relaname); return NULL; + } + + free(relaname); base->rela = sec; sec->base = base; -- 2.11.0