From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdINFbu (ORCPT ); Thu, 14 Sep 2017 01:31:50 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:38115 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdINFbt (ORCPT ); Thu, 14 Sep 2017 01:31:49 -0400 X-Google-Smtp-Source: ADKCNb7fH/cGEKqSx4PLcMkIVavaQyAeRLRAmgwhbYLxS5yFFsTYiczd6+XO9YpowPUYao3ttGKfdA== Date: Thu, 14 Sep 2017 07:31:45 +0200 From: Ingo Molnar To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, Martin Kepplinger Subject: Re: [PATCH] tools: objtool: fix memory leak in elf_create_rela_section() Message-ID: <20170914053145.7clhcoauwecrldi2@gmail.com> References: <8143a814a7c4ed2d099ee2c520f20ff30d2b3e17.1505342451.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8143a814a7c4ed2d099ee2c520f20ff30d2b3e17.1505342451.git.jpoimboe@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Josh Poimboeuf wrote: > From: Martin Kepplinger > > Let's free the allocated char array relaname before returning > in order to avoid leaking memory. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Josh Poimboeuf > --- > tools/objtool/elf.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c > index 6e9f980a7d26..6aacbc31316d 100644 > --- a/tools/objtool/elf.c > +++ b/tools/objtool/elf.c > @@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base) > strcat(relaname, base->name); > > sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0); > - if (!sec) > + if (!sec) { > + free(relaname); > return NULL; > + } > + > + free(relaname); Erm, I'm quite sure if you read this code a second time you'll see how this pattern could be improved! ;-) Thanks, Ingo