From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751359AbdINGCB (ORCPT ); Thu, 14 Sep 2017 02:02:01 -0400 Received: from mout02.posteo.de ([185.67.36.66]:35343 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdINGCA (ORCPT ); Thu, 14 Sep 2017 02:02:00 -0400 From: Martin Kepplinger To: mingo.kernel.org@gmail.com, jpoimboe@redhat.com Cc: linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [PATCH v2] tools: objtool: fix memory leak in elf_create_rela_section() Date: Thu, 14 Sep 2017 08:01:38 +0200 Message-Id: <20170914060138.26472-1-martink@posteo.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170914053145.7clhcoauwecrldi2@gmail.com> References: <20170914053145.7clhcoauwecrldi2@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's free the allocated char array relaname before returning in order to avoid leaking memory. Signed-off-by: Martin Kepplinger --- I should've allocated some brain resources before freeing some computer's. tools/objtool/elf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6e9f980a7d26..1e89a5f8bfc9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base) strcat(relaname, base->name); sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0); + free(relaname); if (!sec) return NULL; -- 2.11.0