From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbdINMur (ORCPT ); Thu, 14 Sep 2017 08:50:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37512 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbdINMuq (ORCPT ); Thu, 14 Sep 2017 08:50:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B422CC04B310 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Thu, 14 Sep 2017 07:50:44 -0500 From: Josh Poimboeuf To: Martin Kepplinger Cc: mingo.kernel.org@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tools: objtool: fix memory leak in elf_create_rela_section() Message-ID: <20170914125044.23mxcexdv6z7nndl@treble> References: <20170914053145.7clhcoauwecrldi2@gmail.com> <20170914060138.26472-1-martink@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170914060138.26472-1-martink@posteo.de> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 14 Sep 2017 12:50:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 14, 2017 at 08:01:38AM +0200, Martin Kepplinger wrote: > Let's free the allocated char array relaname before returning > in order to avoid leaking memory. > > Signed-off-by: Martin Kepplinger > --- > > I should've allocated some brain resources before freeing some computer's. Oops. I also failed to engage the brain. Sometimes the simplest patches are the most deceptive. ;-) Acked-by: Josh Poimboeuf -- Josh