From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbdINPBt (ORCPT ); Thu, 14 Sep 2017 11:01:49 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:43408 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbdINPBs (ORCPT ); Thu, 14 Sep 2017 11:01:48 -0400 X-Greylist: delayed 1609 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Sep 2017 11:01:47 EDT Date: Thu, 14 Sep 2017 16:34:54 +0200 From: Andrew Lunn To: Fahad Kunnathadi Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, soren.brinkmann@xilinx.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: phy: Fix mask value write on gmii2rgmii converter speed register. Message-ID: <20170914143454.GB27601@lunn.ch> References: <1505373391-18697-1-git-send-email-fahad.kunnathadi@dexceldesigns.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505373391-18697-1-git-send-email-fahad.kunnathadi@dexceldesigns.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 14, 2017 at 12:46:31PM +0530, Fahad Kunnathadi wrote: > To clear Speed Selection in MDIO control register(0x10), > ie, clear bits 6 and 13 to zero while keeping other bits same. > Before AND operation,The Mask value has to be perform with bitwise NOT > operation (ie, ~ operator) > > This patch clears current speed selection before writing the > new speed settings to gmii2rgmii converter Hi Fahad I expect you will find other issues with this driver. I pointed some out at the time it is submitted, but the developers went quiet as soon as it was accepted. Anyway, please ensure David Miller gets a copy. The subject line should be: [PATCH net] net: phy: Fix mask value write on gmii2rgmii converter speed register. and include a fixes tag: Fixes: f411a6160bd4 ("net: phy: Add gmiitorgmii converter support") Reviewed-by: Andrew Lunn Andrew