Re: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

On Mon, Sep 11, 2017 at 09:12:18AM -0700, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---

Please make an effort to write changelogs that clearly describe the
change you're making.  This is doing way more than just implementing DSP
mode, it's also adding a fairly complicated set_tdm_slot() implementation 
which isn't mentioned at all.  It probably needs splitting into multiple
patches as well.

> @@ -414,6 +504,9 @@ static int max98927_dac_event(struct snd_soc_dapm_widget *w,
>  	struct max98927_priv *max98927 = snd_soc_codec_get_drvdata(codec);
>  
>  	switch (event) {
> +	case SND_SOC_DAPM_PRE_PMU:
> +		max98927->tdm_mode = 0;
> +		break;
>  	case SND_SOC_DAPM_POST_PMU:
>  		regmap_update_bits(max98927->regmap,
>  			MAX98927_R003A_AMP_EN,

Why is an event associated with the DAC changing something related to
the DAI format?  These things should be unrelated.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]