From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbdIOVWr (ORCPT ); Fri, 15 Sep 2017 17:22:47 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57164 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbdIOVWp (ORCPT ); Fri, 15 Sep 2017 17:22:45 -0400 Date: Fri, 15 Sep 2017 14:22:44 -0700 (PDT) Message-Id: <20170915.142244.2005612745314498019.davem@davemloft.net> To: arnd@arndb.de Cc: dsa@cumulusnetworks.com, shm@cumulusnetworks.com, ja@ssi.bg, mschiffer@universe-factory.net, weiwan@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: vrf: avoid gcc-4.6 warning From: David Miller In-Reply-To: <20170912201100.3680915-1-arnd@arndb.de> References: <20170912201100.3680915-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Sep 2017 14:22:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8FLMpQL028582 From: Arnd Bergmann Date: Tue, 12 Sep 2017 22:10:53 +0200 > When building an allmodconfig kernel with gcc-4.6, we get a rather > odd warning: > > drivers/net/vrf.c: In function ¡vrf_ip6_input_dst¢: > drivers/net/vrf.c:964:3: error: initialized field with side-effects overwritten [-Werror] > drivers/net/vrf.c:964:3: error: (near initialization for ¡fl6¢) [-Werror] > > I have no idea what this warning is even trying to say, but it does > seem like a false positive. Reordering the initialization in to match > the structure definition gets rid of the warning, and might also avoid > whatever gcc thinks is wrong here. > > Fixes: 9ff74384600a ("net: vrf: Handle ipv6 multicast and link-local addresses") > Signed-off-by: Arnd Bergmann That's extremely weird, I can't explain it either. Oh well, applied, thanks.