From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbdIOSpO (ORCPT ); Fri, 15 Sep 2017 14:45:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51832 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbdIOSpN (ORCPT ); Fri, 15 Sep 2017 14:45:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7E1C381E1F Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Fri, 15 Sep 2017 20:45:10 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools: Improve error messages for missing PMUs Message-ID: <20170915184510.GB31734@krava> References: <20170913215006.32222-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170913215006.32222-1-andi@firstfloor.org> User-Agent: Mutt/1.9.0 (2017-09-02) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 15 Sep 2017 18:45:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 13, 2017 at 02:50:06PM -0700, Andi Kleen wrote: > From: Andi Kleen > > When a PMU is missing print a better error message mentioning > the missing PMU. > > % mkdir empty > % mount --bind empty /sys/devices/msr > % perf stat -M Summary true > event syntax error: '{inst_retired.any,cycles}:W,{cpu_clk_unhalted.thread}:W,{inst_retired.any}:W,{cpu_clk_unhalted.ref_tsc,msr/tsc/}:W,{fp_comp_ops_exe.sse_scalar..' > \___ Cannot find PMU `msr'. Missing kernel support? > > It still cannot find the right column for aliases, but it's already a vast improvement. > > v2: Check asprintf > Signed-off-by: Andi Kleen > --- > tools/perf/util/metricgroup.c | 2 +- > tools/perf/util/parse-events.c | 18 ++++++++++++------ > tools/perf/util/parse-events.h | 3 +++ > 3 files changed, 16 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c > index 2d60114f1870..0794f02cbb8f 100644 > --- a/tools/perf/util/metricgroup.c > +++ b/tools/perf/util/metricgroup.c > @@ -477,7 +477,7 @@ int metricgroup__parse_groups(const struct option *opt, > memset(&parse_error, 0, sizeof(struct parse_events_error)); > ret = parse_events(perf_evlist, extra_events.buf, &parse_error); > if (ret) { > - pr_err("Cannot set up events %s\n", extra_events.buf); > + parse_events_print_error(&parse_error, extra_events.buf); nit, mixed tabs/spaces indent, other than that: Acked-by: Jiri Olsa thanks, jirka