From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751843AbdIOUPy (ORCPT ); Fri, 15 Sep 2017 16:15:54 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:55418 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbdIOUPx (ORCPT ); Fri, 15 Sep 2017 16:15:53 -0400 From: Arnd Bergmann To: Patrik Jakobsson , David Airlie Cc: Arnd Bergmann , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Laurent Pinchart , Alex Deucher , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/gma500: initialize gma_clock_t structures Date: Fri, 15 Sep 2017 22:15:27 +0200 Message-Id: <20170915201537.2050843-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:uvBtHerMLZLhqgLKDekAUTC95InQ+C8wynzNYqImQbPfc9FefLp aARgfT244TDlsAo1Dx1ozEqyt5VWwludj2QAJ097tGE3e837tXz7bHmJt+9oenJRUmO9z0s /TDqwbrxX9oaR+H9UKOCTYCGisyEKe7bvY9hFmflNjGk7agYuSJDLctkxRX32fLyQvjKKqd U24MAg9z1ZYNyt9Eg4IrQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Tru9Mq1PwqQ=:4xin1hwpnhbStcbS1tpbHh WDAvQNB5PT3R66L7x5rsYaQe0PatQvCCWyvM3H3NSVZpfWy5DSTfTPi2PL1Rw7aLvirISSwtn M6XE1mTpG8epILENxO6YaBifUeeiQpSUjvmFrvxEtzOkKGOmRSm5DDm2T89RRrk6TygJddNWg 5NNkS0RPgfZQHpDXUFR98bAWCMlL79tI9MqLZCDF7vdg0e7slZNAvjCaUdxGIOgauqoAY2NeM xXUCfTjhrKvMHComL4oM66yjdE06zHdxIiG7tj3/o/gWxhUEBC/UE8CSRehQiAn8IE/03PTeo doB28imnnbS7m4DKi7f8zqSPfZcMXkqLWoeAR9QKJZYwbzB+/jNu3WFIEkAojWgi5KWA5fvYt ehnDTIsBBKhIxRPMUKuveD8M1f6/YlrF/uQxDDwQR+OaW3MHOWrDHJUaur8W45LlYNGNtTO2z JmGxpO0TggU+ScIhurvDPuyBOeqKIGZS8NtipplFhZRllwisDSR+w8xqjuPRkjNhkNJIl/tDb JWPrNSgwR8+u9madJrcXFOFc1UhdT7BVxLOk0HTPJMieW5kR/u1gQwNhOuefRS++eKOyy/SPM HBXwBnZsEkLN/1qYA18nB1nJf97IvK/yB7v3YoSmhoQJ+3dX/XfhLDjjezZ36M20Xza0O1oF+ lSwa7UVkbkKYTd9qb1AoELIFIBmicFgANs1s5aZexnAqnBHXRiY0ati6zWw21k863B+xYJNWo rak/cCbHHSjEAAk/hHKmuEAs47ejzYh4uvP1VA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The two functions pass a partially initialized structure back to the caller after a memset() on the destination. This is not entirely well-defined, most compilers are sensible enough to either keep the zero-initialization for the uninitialized members, but gcc-4.4 does not, and it warns about this: drivers/gpu/drm/gma500/oaktrail_crtc.c: In function 'mrst_sdvo_find_best_pll': drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.vco' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.dot' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.p2' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.m2' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c:175: warning: 'clock.m1' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c: In function 'mrst_lvds_find_best_pll': drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.p' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.vco' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.p2' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.m2' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.m1' may be used uninitialized in this function drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.n' may be used uninitialized in this function This adds an initialization at declaration time to avoid the warning and make it well-defined on all compiler versions. Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/gma500/oaktrail_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c index 0fff269d3fe6..b49fe79c3f44 100644 --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c @@ -134,7 +134,7 @@ static bool mrst_sdvo_find_best_pll(const struct gma_limit_t *limit, struct drm_crtc *crtc, int target, int refclk, struct gma_clock_t *best_clock) { - struct gma_clock_t clock; + struct gma_clock_t clock = {}; u32 target_vco, actual_freq; s32 freq_error, min_error = 100000; @@ -191,7 +191,7 @@ static bool mrst_lvds_find_best_pll(const struct gma_limit_t *limit, struct drm_crtc *crtc, int target, int refclk, struct gma_clock_t *best_clock) { - struct gma_clock_t clock; + struct gma_clock_t clock = {}; int err = target; memset(best_clock, 0, sizeof(*best_clock)); -- 2.9.0