From: kbuild test robot <lkp@intel.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: kbuild-all@01.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux@armlinux.org.uk, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, daniel.lezcano@linaro.org,
tglx@linutronix.de, ludovic.barre@st.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: Re: [PATCH 1/2] clocksource: stm32: rework driver to use only one timer
Date: Sat, 16 Sep 2017 02:27:21 +0800 [thread overview]
Message-ID: <201709160224.qv6Npq2c%fengguang.wu@intel.com> (raw)
In-Reply-To: <1505375812-19037-2-git-send-email-benjamin.gaignard@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 3136 bytes --]
Hi Benjamin,
[auto build test WARNING on tip/timers/core]
[also build test WARNING on next-20170915]
[cannot apply to robh/for-next v4.13]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Benjamin-Gaignard/stm32-clocksource-driver-rework/20170915-220617
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/clocksource/timer-stm32.c: In function 'stm32_timer_init':
>> drivers/clocksource/timer-stm32.c:180:11: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]
int irq, err;
^~~
vim +/err +180 drivers/clocksource/timer-stm32.c
173
174 static int __init stm32_timer_init(struct device_node *node)
175 {
176 struct reset_control *rstc;
177 void __iomem *timer_base;
178 unsigned long max_arr;
179 struct clk *clk;
> 180 int irq, err;
181
182 timer_base = of_io_request_and_map(node, 0, of_node_full_name(node));
183 if (IS_ERR(timer_base)) {
184 pr_err("Can't map registers\n");
185 goto out;
186 }
187
188 irq = irq_of_parse_and_map(node, 0);
189 if (irq <= 0) {
190 pr_err("Can't parse IRQ\n");
191 goto out_unmap;
192 }
193
194 clk = of_clk_get(node, 0);
195 if (IS_ERR(clk)) {
196 pr_err("Can't get timer clock\n");
197 goto out_unmap;
198 }
199
200 rstc = of_reset_control_get(node, NULL);
201 if (!IS_ERR(rstc)) {
202 reset_control_assert(rstc);
203 reset_control_deassert(rstc);
204 }
205
206 err = clk_prepare_enable(clk);
207 if (err) {
208 pr_err("Couldn't enable parent clock\n");
209 goto out_clk;
210 }
211
212 /* Detect whether the timer is 16 or 32 bits */
213 writel_relaxed(~0U, timer_base + TIM_ARR);
214 max_arr = readl_relaxed(timer_base + TIM_ARR);
215 if (max_arr != ~0U) {
216 err = -EINVAL;
217 pr_err("32 bits timer is needed\n");
218 goto out_unprepare;
219 }
220
221 err = stm32_clocksource_init(node, timer_base, clk);
222 if (err)
223 goto out_unprepare;
224
225 err = stm32_clockevent_init(node, timer_base, clk, irq);
226 if (err)
227 goto out_unprepare;
228
229 return 0;
230
231 out_unprepare:
232 clk_disable_unprepare(clk);
233 out_clk:
234 clk_put(clk);
235 out_unmap:
236 iounmap(timer_base);
237 out:
238 return err;
239 }
240
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62854 bytes --]
next prev parent reply other threads:[~2017-09-15 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 7:56 [PATCH 0/2] stm32 clocksource driver rework Benjamin Gaignard
2017-09-14 7:56 ` [PATCH 1/2] clocksource: stm32: rework driver to use only one timer Benjamin Gaignard
2017-09-15 18:27 ` kbuild test robot [this message]
2017-09-18 21:30 ` Daniel Lezcano
2017-09-19 7:59 ` Benjamin Gaignard
2017-09-19 15:54 ` Daniel Lezcano
2017-09-14 7:56 ` [PATCH 2/2] arm: dts: stm32: remove useless clocksource nodes Benjamin Gaignard
2017-09-15 21:03 ` Daniel Lezcano
2017-09-17 13:34 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201709160224.qv6Npq2c%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ludovic.barre@st.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®