From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbdIPJeR (ORCPT ); Sat, 16 Sep 2017 05:34:17 -0400 Received: from outbound-smtp09.blacknight.com ([46.22.139.14]:35117 "EHLO outbound-smtp09.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbdIPJeP (ORCPT ); Sat, 16 Sep 2017 05:34:15 -0400 Date: Sat, 16 Sep 2017 10:34:12 +0100 From: Mel Gorman To: Arnd Bergmann Cc: Andrew Morton , Michal Hocko , Vlastimil Babka , Hillf Danton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: meminit: mark init_reserved_page as __meminit Message-ID: <20170916093412.xdqb7wne4s5xufeq@techsingularity.net> References: <20170915193149.901180-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20170915193149.901180-1-arnd@arndb.de> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 15, 2017 at 09:31:30PM +0200, Arnd Bergmann wrote: > The function is called from __meminit context and calls other > __meminit functions but isn't it self mark as such today: > > WARNING: vmlinux.o(.text.unlikely+0x4516): Section mismatch in reference from the function init_reserved_page() to the function .meminit.text:early_pfn_to_nid() > The function init_reserved_page() references > the function __meminit early_pfn_to_nid(). > This is often because init_reserved_page lacks a __meminit > annotation or the annotation of early_pfn_to_nid is wrong. > > On most compilers, we don't notice this because the function > gets inlined all the time. Adding __meminit here fixes the > harmless warning for the old versions and is generally the > correct annotation. > > Fixes: 7e18adb4f80b ("mm: meminit: initialise remaining struct pages in parallel with kswapd") > Signed-off-by: Arnd Bergmann Acked-by: Mel Gorman -- Mel Gorman SUSE Labs