From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755445AbdIROsC (ORCPT ); Mon, 18 Sep 2017 10:48:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:43704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753112AbdIROsB (ORCPT ); Mon, 18 Sep 2017 10:48:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 300AF21A2A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 18 Sep 2017 10:47:58 -0400 From: Steven Rostedt To: Byungchul Park Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, juri.lelli@gmail.com, kernel-team@lge.com Subject: Re: [PATCH v2 1/2] sched/deadline: Add cpudl_maximum_dl() for clean-up Message-ID: <20170918104758.5f349a08@gandalf.local.home> In-Reply-To: <1505351119-1044-1-git-send-email-byungchul.park@lge.com> References: <1505351119-1044-1-git-send-email-byungchul.park@lge.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Sep 2017 10:05:18 +0900 Byungchul Park wrote: > Changes from v1 > - Enhance commit msg > - Prevent WARN in cpumask_test_cpu() in cpudl_find() when best_cpu == -1 > > -----8<----- > >From 7735382d07ae6a61d740ae39ba2ecf169d43b8a2 Mon Sep 17 00:00:00 2001 > From: Byungchul Park > Date: Wed, 22 Mar 2017 14:25:56 +0900 > Subject: [PATCH v2 1/2] sched/deadline: Add cpudl_maximum_dl() for clean-up > > Current code uses cpudl_maximum() to get the root node's cpu, while it > directly accesses the root node like 'cp->elements[0].dl' to get the > root node's dl. It would be more readible to add a function for the dl, > as well. Added it. Looks fine to me. Acked-by: Steven Rostedt (VMware) -- Steve > > Signed-off-by: Byungchul Park > --- > kernel/sched/cpudeadline.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c > index 8d9562d..9f02035 100644 > --- a/kernel/sched/cpudeadline.c > +++ b/kernel/sched/cpudeadline.c > @@ -108,11 +108,16 @@ static void cpudl_heapify(struct cpudl *cp, int idx) > cpudl_heapify_down(cp, idx); > } > > -static inline int cpudl_maximum(struct cpudl *cp) > +static inline int cpudl_maximum_cpu(struct cpudl *cp) > { > return cp->elements[0].cpu; > } > > +static inline u64 cpudl_maximum_dl(struct cpudl *cp) > +{ > + return cp->elements[0].dl; > +} > + > /* > * cpudl_find - find the best (later-dl) CPU in the system > * @cp: the cpudl max-heap context > @@ -130,11 +135,11 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p, > cpumask_and(later_mask, cp->free_cpus, &p->cpus_allowed)) { > return 1; > } else { > - int best_cpu = cpudl_maximum(cp); > + int best_cpu = cpudl_maximum_cpu(cp); > WARN_ON(best_cpu != -1 && !cpu_present(best_cpu)); > > if (cpumask_test_cpu(best_cpu, &p->cpus_allowed) && > - dl_time_before(dl_se->deadline, cp->elements[0].dl)) { > + dl_time_before(dl_se->deadline, cpudl_maximum_dl(cp))) { > if (later_mask) > cpumask_set_cpu(best_cpu, later_mask); >