From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbdIRXru (ORCPT ); Mon, 18 Sep 2017 19:47:50 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:53533 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdIRXrs (ORCPT ); Mon, 18 Sep 2017 19:47:48 -0400 Date: Mon, 18 Sep 2017 16:47:45 -0700 From: Christoph Hellwig To: Waiman Long Cc: Jens Axboe , Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-nilfs@vger.kernel.org, cluster-devel@redhat.com, Bart Van Assche Subject: Re: [PATCH v6 2/2] block_dev: Rename bd_fsfreeze_mutex Message-ID: <20170918234745.GA8600@infradead.org> References: <1505760831-7747-1-git-send-email-longman@redhat.com> <1505760831-7747-3-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1505760831-7747-3-git-send-email-longman@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Don't rename it to a way to long name. Either add a separate mutex for your purpose (unless there is interaction between freezing and blktrace, which I doubt), or properly comment the usage.