From: Christoph Hellwig <hch@infradead.org>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: move sanity checking ahead of bi_front/back_seg_size updating
Date: Mon, 18 Sep 2017 16:51:10 -0700 [thread overview]
Message-ID: <20170918235110.GB8600@infradead.org> (raw)
In-Reply-To: <1505517030-29287-1-git-send-email-jianchao.w.wang@oracle.com>
On Sat, Sep 16, 2017 at 07:10:30AM +0800, Jianchao Wang wrote:
> If the bio_integrity_merge_rq() return false or nr_phys_segments exceeds
> the max_segments, the merging fails, but the bi_front/back_seg_size may
> have been modified. To avoid it, move the sanity checking ahead.
>
> Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
This looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But can you elaborate a little more on how this found and if there
is a way to easily reproduce it, say for a blktests test case?
next prev parent reply other threads:[~2017-09-18 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 23:10 Jianchao Wang
2017-09-18 23:51 ` Christoph Hellwig [this message]
2017-09-19 0:55 ` jianchao.wang
2017-09-19 14:36 ` Christoph Hellwig
2017-09-20 1:38 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918235110.GB8600@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®