From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
andrew@lunn.ch
Subject: Re: [PATCH net-next 0/4] net: dsa: move master ethtool code
Date: Tue, 19 Sep 2017 16:04:38 -0700 (PDT) [thread overview]
Message-ID: <20170919.160438.114096071481057977.davem@davemloft.net> (raw)
In-Reply-To: <80b8afa0-e269-c0b7-da4a-dcb604a239ca@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 19 Sep 2017 13:04:56 -0700
> On 09/19/2017 08:56 AM, Vivien Didelot wrote:
>> The DSA core overrides the master device's ethtool_ops structure so that
>> it can inject statistics and such of its dedicated switch CPU port.
>>
>> This ethtool code is currently called on unnecessary conditions or
>> before the master interface and its switch CPU port get wired up.
>> This patchset fixes this.
>>
>> Similarly to slave.c where the DSA slave net_device is the entry point
>> of the dsa_slave_* functions, this patchset also isolates the master's
>> ethtool code in a new master.c file, where the DSA master net_device is
>> the entry point of the dsa_master_* functions.
>>
>> This is a first step towards better control of the master device and
>> support for multiple CPU ports.
>
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
>
> * ethtool -S eth0 -> switch port CPU stats are still correctly overlayed
> * ethtool -s gphy wol g -> both switch port and CPU port correctly
> enable WoL
> * ethtool -i eth0 -> driver still reports correct information
Series applied, thanks everyone.
prev parent reply other threads:[~2017-09-19 23:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 15:56 Vivien Didelot
2017-09-19 15:56 ` [PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops Vivien Didelot
2017-09-19 19:55 ` Florian Fainelli
2017-09-19 15:56 ` [PATCH net-next 2/4] net: dsa: setup master ethtool unconditionally Vivien Didelot
2017-09-19 17:48 ` Florian Fainelli
2017-09-19 15:56 ` [PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr Vivien Didelot
2017-09-19 17:49 ` Florian Fainelli
2017-09-19 15:57 ` [PATCH net-next 4/4] net: dsa: move master ethtool code Vivien Didelot
2017-09-19 19:56 ` Florian Fainelli
2017-09-19 20:04 ` [PATCH net-next 0/4] " Florian Fainelli
2017-09-19 23:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919.160438.114096071481057977.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®