From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751394AbdISDY6 (ORCPT ); Mon, 18 Sep 2017 23:24:58 -0400 Received: from mail-qt0-f179.google.com ([209.85.216.179]:53513 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbdISDY4 (ORCPT ); Mon, 18 Sep 2017 23:24:56 -0400 X-Google-Smtp-Source: AOwi7QC+za4I645hWj/6OJPpPhjoreVBq/Gtl9Rw7ijhLq/Op3I64KaRnE1t7ldnvF6Wq259xFZaOw== Date: Mon, 18 Sep 2017 20:24:52 -0700 From: Tejun Heo To: Colin King Cc: Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: pata_artop: remove redundant initialization of pio Message-ID: <20170919032452.GN378890@devbig577.frc2.facebook.com> References: <20170914185418.13790-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170914185418.13790-1-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 14, 2017 at 07:54:18PM +0100, Colin King wrote: > From: Colin Ian King > > pio is initialized and the data is never read, instead it is almost > immediately being updated to a new value. Fix this by removing the > initialization. > > Detected by scan-build: > "warning: Value stored to 'pio' during its initialization is never read" > > Fixes: 669a5db411d8 ("[libata] Add a bunch of PATA drivers") > Signed-off-by: Colin Ian King Applied to libata/for-4.15. Thanks. -- tejun