From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377AbdISDaD (ORCPT ); Mon, 18 Sep 2017 23:30:03 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:38202 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbdISDaA (ORCPT ); Mon, 18 Sep 2017 23:30:00 -0400 X-Google-Smtp-Source: AOwi7QDGI2Q/TsoWYl819TCapzoRU7WdKLpBbVaSIR9rRJhqJPgNTYEW+ib9MAIaK3I2OriT24M8Jw== Date: Mon, 18 Sep 2017 20:29:56 -0700 From: Tejun Heo To: Colin King Cc: Mark Fasheh , Joel Becker , Andrew Morton , piaojun , linux-ide@vger.kernel.org, ocfs2-devel@oss.oracle.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] libata: make static arrays const, reduces object code size Message-ID: <20170919032956.GP378890@devbig577.frc2.facebook.com> References: <20170918133140.31220-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170918133140.31220-1-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 18, 2017 at 02:31:40PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate const arrayis on the stack, instead make them static. > Makes the object code smaller by over 260 bytes: > > Signed-off-by: Colin Ian King ... > diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c > index 74407c6dd592..31a61e8e0152 100644 > --- a/fs/ocfs2/dlm/dlmrecovery.c > +++ b/fs/ocfs2/dlm/dlmrecovery.c > @@ -1129,7 +1129,6 @@ static int dlm_send_mig_lockres_msg(struct dlm_ctxt *dlm, > (mres->num_locks * sizeof(struct dlm_migratable_lock)); > > /* add an all-done flag if we reached the last lock */ > - orig_flags = mres->flags; > BUG_ON(total_locks > mres_total_locks); > if (total_locks == mres_total_locks) > mres->flags |= DLM_MRES_ALL_DONE; Looks like patch contamination. Thanks. -- tejun